netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] doc: fix seg6_flowlabel path
@ 2025-10-10 14:18 Nicolas Dichtel
  2025-10-11  8:02 ` Simon Horman
  2025-10-12 22:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2025-10-10 14:18 UTC (permalink / raw)
  To: David Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet,
	Jonathan Corbet
  Cc: netdev, linux-doc, Nicolas Dichtel, Philippe Guibert

This sysctl is not per interface; it's global per netns.

Fixes: 292ecd9f5a94 ("doc: move seg6_flowlabel to seg6-sysctl.rst")
Reported-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 Documentation/networking/seg6-sysctl.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/networking/seg6-sysctl.rst b/Documentation/networking/seg6-sysctl.rst
index 07c20e470baf..1b6af4779be1 100644
--- a/Documentation/networking/seg6-sysctl.rst
+++ b/Documentation/networking/seg6-sysctl.rst
@@ -25,6 +25,9 @@ seg6_require_hmac - INTEGER
 
 	Default is 0.
 
+/proc/sys/net/ipv6/seg6_* variables:
+====================================
+
 seg6_flowlabel - INTEGER
 	Controls the behaviour of computing the flowlabel of outer
 	IPv6 header in case of SR T.encaps
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] doc: fix seg6_flowlabel path
  2025-10-10 14:18 [PATCH net] doc: fix seg6_flowlabel path Nicolas Dichtel
@ 2025-10-11  8:02 ` Simon Horman
  2025-10-12 22:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-10-11  8:02 UTC (permalink / raw)
  To: Nicolas Dichtel
  Cc: David Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet,
	Jonathan Corbet, netdev, linux-doc, Philippe Guibert

On Fri, Oct 10, 2025 at 04:18:59PM +0200, Nicolas Dichtel wrote:
> This sysctl is not per interface; it's global per netns.
> 
> Fixes: 292ecd9f5a94 ("doc: move seg6_flowlabel to seg6-sysctl.rst")
> Reported-by: Philippe Guibert <philippe.guibert@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Thanks.

Thinking aloud:

I see that above the lines added by this patch are documentation
for the variables seg6_require_hmac and seg6_enabled. Which
are per interface. And thus documented correctly.

And below the lines added by the patch is only seg6_flowlabel.
Which, as the patch description says, are global rather than
per interface. And with this patch that is now documented correctly too.

I also agree that this problem was introduced by the cited commit.

And as a documentation correction it seems appropriate for net.

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] doc: fix seg6_flowlabel path
  2025-10-10 14:18 [PATCH net] doc: fix seg6_flowlabel path Nicolas Dichtel
  2025-10-11  8:02 ` Simon Horman
@ 2025-10-12 22:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-12 22:00 UTC (permalink / raw)
  To: Nicolas Dichtel
  Cc: davem, kuba, pabeni, edumazet, corbet, netdev, linux-doc,
	philippe.guibert

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 10 Oct 2025 16:18:59 +0200 you wrote:
> This sysctl is not per interface; it's global per netns.
> 
> Fixes: 292ecd9f5a94 ("doc: move seg6_flowlabel to seg6-sysctl.rst")
> Reported-by: Philippe Guibert <philippe.guibert@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>  Documentation/networking/seg6-sysctl.rst | 3 +++
>  1 file changed, 3 insertions(+)

Here is the summary with links:
  - [net] doc: fix seg6_flowlabel path
    https://git.kernel.org/netdev/net/c/0b4b77eff5f8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-12 22:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-10 14:18 [PATCH net] doc: fix seg6_flowlabel path Nicolas Dichtel
2025-10-11  8:02 ` Simon Horman
2025-10-12 22:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).