netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 0/2] net: airoha: Add some new ethtool bits
@ 2025-10-13 14:29 Lorenzo Bianconi
  2025-10-13 14:29 ` [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats Lorenzo Bianconi
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Lorenzo Bianconi @ 2025-10-13 14:29 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lorenzo Bianconi
  Cc: linux-arm-kernel, linux-mediatek, netdev

- add missing stats to ethtool ethtool_eth_mac_stats struct
- set get_link ethtool callback to ethtool_op_get_link routine

---
Lorenzo Bianconi (2):
      net: airoha: Add missing stats to ethtool_eth_mac_stats
      net: airoha: Add get_link ethtool callback

 drivers/net/ethernet/airoha/airoha_eth.c | 5 +++++
 1 file changed, 5 insertions(+)
---
base-commit: 18a7e218cfcdca6666e1f7356533e4c988780b57
change-id: 20251002-airoha-ethtool-improvements-08266c4a9d09

Best regards,
-- 
Lorenzo Bianconi <lorenzo@kernel.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats
  2025-10-13 14:29 [PATCH net-next 0/2] net: airoha: Add some new ethtool bits Lorenzo Bianconi
@ 2025-10-13 14:29 ` Lorenzo Bianconi
  2025-10-13 14:49   ` Andrew Lunn
  2025-10-13 14:29 ` [PATCH net-next 2/2] net: airoha: Add get_link ethtool callback Lorenzo Bianconi
  2025-10-15  2:50 ` [PATCH net-next 0/2] net: airoha: Add some new ethtool bits patchwork-bot+netdevbpf
  2 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2025-10-13 14:29 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lorenzo Bianconi
  Cc: linux-arm-kernel, linux-mediatek, netdev

Add the following stats to ethtool ethtool_eth_mac_stats stats:
- FramesTransmittedOK
- OctetsTransmittedOK
- FramesReceivedOK
- OctetsReceivedOK

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/airoha/airoha_eth.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
index 833dd911980b3f698bd7e5f9fd9e2ce131dd5222..2fe1f39558b80926439cc2f765eb5057464dd76e 100644
--- a/drivers/net/ethernet/airoha/airoha_eth.c
+++ b/drivers/net/ethernet/airoha/airoha_eth.c
@@ -2022,8 +2022,12 @@ static void airoha_ethtool_get_mac_stats(struct net_device *dev,
 	airoha_update_hw_stats(port);
 	do {
 		start = u64_stats_fetch_begin(&port->stats.syncp);
+		stats->FramesTransmittedOK = port->stats.tx_ok_pkts;
+		stats->OctetsTransmittedOK = port->stats.tx_ok_bytes;
 		stats->MulticastFramesXmittedOK = port->stats.tx_multicast;
 		stats->BroadcastFramesXmittedOK = port->stats.tx_broadcast;
+		stats->FramesReceivedOK = port->stats.rx_ok_pkts;
+		stats->OctetsReceivedOK = port->stats.rx_ok_bytes;
 		stats->BroadcastFramesReceivedOK = port->stats.rx_broadcast;
 	} while (u64_stats_fetch_retry(&port->stats.syncp, start));
 }

-- 
2.51.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next 2/2] net: airoha: Add get_link ethtool callback
  2025-10-13 14:29 [PATCH net-next 0/2] net: airoha: Add some new ethtool bits Lorenzo Bianconi
  2025-10-13 14:29 ` [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats Lorenzo Bianconi
@ 2025-10-13 14:29 ` Lorenzo Bianconi
  2025-10-13 14:47   ` Andrew Lunn
  2025-10-15  2:50 ` [PATCH net-next 0/2] net: airoha: Add some new ethtool bits patchwork-bot+netdevbpf
  2 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2025-10-13 14:29 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Lorenzo Bianconi
  Cc: linux-arm-kernel, linux-mediatek, netdev

Set get_link ethtool callback to ethtool_op_get_link routine.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/airoha/airoha_eth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
index 2fe1f39558b80926439cc2f765eb5057464dd76e..6effdda64380bf72ce3c5b6b2f551f560f2ee097 100644
--- a/drivers/net/ethernet/airoha/airoha_eth.c
+++ b/drivers/net/ethernet/airoha/airoha_eth.c
@@ -2770,6 +2770,7 @@ static const struct ethtool_ops airoha_ethtool_ops = {
 	.get_drvinfo		= airoha_ethtool_get_drvinfo,
 	.get_eth_mac_stats      = airoha_ethtool_get_mac_stats,
 	.get_rmon_stats		= airoha_ethtool_get_rmon_stats,
+	.get_link		= ethtool_op_get_link,
 };
 
 static int airoha_metadata_dst_alloc(struct airoha_gdm_port *port)

-- 
2.51.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next 2/2] net: airoha: Add get_link ethtool callback
  2025-10-13 14:29 ` [PATCH net-next 2/2] net: airoha: Add get_link ethtool callback Lorenzo Bianconi
@ 2025-10-13 14:47   ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2025-10-13 14:47 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, linux-arm-kernel, linux-mediatek, netdev

On Mon, Oct 13, 2025 at 04:29:42PM +0200, Lorenzo Bianconi wrote:
> Set get_link ethtool callback to ethtool_op_get_link routine.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats
  2025-10-13 14:29 ` [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats Lorenzo Bianconi
@ 2025-10-13 14:49   ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2025-10-13 14:49 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, linux-arm-kernel, linux-mediatek, netdev

On Mon, Oct 13, 2025 at 04:29:41PM +0200, Lorenzo Bianconi wrote:
> Add the following stats to ethtool ethtool_eth_mac_stats stats:
> - FramesTransmittedOK
> - OctetsTransmittedOK
> - FramesReceivedOK
> - OctetsReceivedOK
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next 0/2] net: airoha: Add some new ethtool bits
  2025-10-13 14:29 [PATCH net-next 0/2] net: airoha: Add some new ethtool bits Lorenzo Bianconi
  2025-10-13 14:29 ` [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats Lorenzo Bianconi
  2025-10-13 14:29 ` [PATCH net-next 2/2] net: airoha: Add get_link ethtool callback Lorenzo Bianconi
@ 2025-10-15  2:50 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-15  2:50 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-arm-kernel,
	linux-mediatek, netdev

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 13 Oct 2025 16:29:40 +0200 you wrote:
> - add missing stats to ethtool ethtool_eth_mac_stats struct
> - set get_link ethtool callback to ethtool_op_get_link routine
> 
> ---
> Lorenzo Bianconi (2):
>       net: airoha: Add missing stats to ethtool_eth_mac_stats
>       net: airoha: Add get_link ethtool callback
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats
    https://git.kernel.org/netdev/net-next/c/331f8a8bea22
  - [net-next,2/2] net: airoha: Add get_link ethtool callback
    https://git.kernel.org/netdev/net-next/c/fc4fed9054ef

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-10-15  2:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-13 14:29 [PATCH net-next 0/2] net: airoha: Add some new ethtool bits Lorenzo Bianconi
2025-10-13 14:29 ` [PATCH net-next 1/2] net: airoha: Add missing stats to ethtool_eth_mac_stats Lorenzo Bianconi
2025-10-13 14:49   ` Andrew Lunn
2025-10-13 14:29 ` [PATCH net-next 2/2] net: airoha: Add get_link ethtool callback Lorenzo Bianconi
2025-10-13 14:47   ` Andrew Lunn
2025-10-15  2:50 ` [PATCH net-next 0/2] net: airoha: Add some new ethtool bits patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).