From: Jesper Dangaard Brouer <hawk@kernel.org>
To: netdev@vger.kernel.org, makita.toshiaki@lab.ntt.co.jp
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
ihor.solodrai@linux.dev, toshiaki.makita1@gmail.com,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@cloudflare.com
Subject: [PATCH net V1 2/3] veth: stop and start all TX queue in netdev down/up
Date: Thu, 23 Oct 2025 16:59:37 +0200 [thread overview]
Message-ID: <176123157775.2281302.5972243809904783041.stgit@firesoul> (raw)
In-Reply-To: <176123150256.2281302.7000617032469740443.stgit@firesoul>
The veth driver started manipulating TXQ states in commit
dc82a33297fc ("veth: apply qdisc backpressure on full ptr_ring
to reduce TX drops").
Other drivers manipulating TXQ states takes care of stopping
and starting TXQs in NDOs. Thus, adding this to veth .ndo_open
and .ndo_stop.
Fixes: dc82a33297fc ("veth: apply qdisc backpressure on full ptr_ring to reduce TX drops")
Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
---
drivers/net/veth.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 7b1a9805b270..3976ddda5fb8 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1404,6 +1404,9 @@ static int veth_open(struct net_device *dev)
return err;
}
+ netif_tx_start_all_queues(dev);
+ netif_tx_start_all_queues(peer);
+
if (peer->flags & IFF_UP) {
netif_carrier_on(dev);
netif_carrier_on(peer);
@@ -1423,6 +1426,10 @@ static int veth_close(struct net_device *dev)
if (peer)
netif_carrier_off(peer);
+ netif_tx_stop_all_queues(dev);
+ if (peer)
+ netif_tx_stop_all_queues(peer);
+
if (priv->_xdp_prog)
veth_disable_xdp(dev);
else if (veth_gro_requested(dev))
next prev parent reply other threads:[~2025-10-23 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 14:59 [PATCH net V1 0/3] veth: Fix TXQ stall race condition and add recovery Jesper Dangaard Brouer
2025-10-23 14:59 ` [PATCH net V1 1/3] veth: enable dev_watchdog for detecting stalled TXQs Jesper Dangaard Brouer
2025-10-24 13:39 ` Toke Høiland-Jørgensen
2025-10-27 11:41 ` Jesper Dangaard Brouer
2025-10-27 14:09 ` Toke Høiland-Jørgensen
2025-10-27 16:18 ` Jesper Dangaard Brouer
2025-10-23 14:59 ` Jesper Dangaard Brouer [this message]
2025-10-25 0:54 ` [PATCH net V1 2/3] veth: stop and start all TX queue in netdev down/up Jakub Kicinski
2025-10-27 10:33 ` Jesper Dangaard Brouer
2025-10-23 14:59 ` [PATCH net V1 3/3] veth: more robust handing of race to avoid txq getting stuck Jesper Dangaard Brouer
2025-10-24 14:33 ` Toke Høiland-Jørgensen
2025-10-27 12:19 ` Jesper Dangaard Brouer
2025-10-27 14:12 ` Toke Høiland-Jørgensen
2025-10-27 19:22 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176123157775.2281302.5972243809904783041.stgit@firesoul \
--to=hawk@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox