* [PATCH] xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules
@ 2025-11-03 3:22 Chu Guangqing
2025-11-03 13:19 ` Jürgen Groß
2025-11-05 1:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Chu Guangqing @ 2025-11-03 3:22 UTC (permalink / raw)
To: jgross, sstabellini, oleksandr_tyshchenko, andrew+netdev, davem,
edumazet, kuba, pabeni
Cc: xen-devel, netdev, linux-kernel, Chu Guangqing
The original comments contained spelling errors and incomplete logical
descriptions, which could easily lead to misunderstandings of the code
logic. The specific modifications are as follows:
Correct the spelling error by changing "inut max" to "but not exceed the
maximum limit";
Add the note "If the user has not specified a value, the default maximum
limit is 8" to clarify the default value logic;
Improve the coherence of the statement to make the queue quantity rules
clearer.
After the modification, the comments can accurately reflect the code
behavior of "taking the smaller value between the number of CPUs and the
default maximum limit of 8 for the number of queues", enhancing code
maintainability.
Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
---
drivers/net/xen-netfront.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index a11a0e949400..7c2220366623 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2696,8 +2696,9 @@ static int __init netif_init(void)
pr_info("Initialising Xen virtual ethernet driver\n");
- /* Allow as many queues as there are CPUs inut max. 8 if user has not
- * specified a value.
+ /* Allow the number of queues to match the number of CPUs, but not exceed
+ * the maximum limit. If the user has not specified a value, the default
+ * maximum limit is 8.
*/
if (xennet_max_queues == 0)
xennet_max_queues = min_t(unsigned int, MAX_QUEUES_DEFAULT,
--
2.43.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules
2025-11-03 3:22 [PATCH] xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules Chu Guangqing
@ 2025-11-03 13:19 ` Jürgen Groß
2025-11-05 1:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jürgen Groß @ 2025-11-03 13:19 UTC (permalink / raw)
To: Chu Guangqing, sstabellini, oleksandr_tyshchenko, andrew+netdev,
davem, edumazet, kuba, pabeni
Cc: xen-devel, netdev, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 930 bytes --]
On 03.11.25 04:22, Chu Guangqing wrote:
> The original comments contained spelling errors and incomplete logical
> descriptions, which could easily lead to misunderstandings of the code
> logic. The specific modifications are as follows:
>
> Correct the spelling error by changing "inut max" to "but not exceed the
> maximum limit";
>
> Add the note "If the user has not specified a value, the default maximum
> limit is 8" to clarify the default value logic;
>
> Improve the coherence of the statement to make the queue quantity rules
> clearer.
>
> After the modification, the comments can accurately reflect the code
> behavior of "taking the smaller value between the number of CPUs and the
> default maximum limit of 8 for the number of queues", enhancing code
> maintainability.
>
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules
2025-11-03 3:22 [PATCH] xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules Chu Guangqing
2025-11-03 13:19 ` Jürgen Groß
@ 2025-11-05 1:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-05 1:10 UTC (permalink / raw)
To: Chu Guangqing
Cc: jgross, sstabellini, oleksandr_tyshchenko, andrew+netdev, davem,
edumazet, kuba, pabeni, xen-devel, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 3 Nov 2025 11:22:12 +0800 you wrote:
> The original comments contained spelling errors and incomplete logical
> descriptions, which could easily lead to misunderstandings of the code
> logic. The specific modifications are as follows:
>
> Correct the spelling error by changing "inut max" to "but not exceed the
> maximum limit";
>
> [...]
Here is the summary with links:
- xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules
https://git.kernel.org/netdev/net-next/c/52665fcc2241
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-05 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-03 3:22 [PATCH] xen/netfront: Comment Correction: Fix Spelling Error and Description of Queue Quantity Rules Chu Guangqing
2025-11-03 13:19 ` Jürgen Groß
2025-11-05 1:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).