From: patchwork-bot+netdevbpf@kernel.org
To: Russell King (Oracle) <linux@armlinux.org.uk>
Cc: andrew@lunn.ch, hkallweit1@gmail.com,
alexandre.torgue@foss.st.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next 0/2] net: stmmac: sanitise stmmac_is_jumbo_frm()
Date: Wed, 19 Nov 2025 16:40:12 +0000 [thread overview]
Message-ID: <176357041250.873046.17131882776763838281.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <aRxDqJSWxOdOaRt4@shell.armlinux.org.uk>
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 18 Nov 2025 10:00:08 +0000 you wrote:
> stmmac_is_jumbo_frm() takes skb->len, which is unsigned int, but the
> parameter is passed as an "int" and then tested using signed
> comparisons. This can cause bugs. Change the parameter to be unsigned.
>
> Also arrange for it to return a bool.
>
> drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 9 ++++-----
> drivers/net/ethernet/stmicro/stmmac/hwif.h | 2 +-
> drivers/net/ethernet/stmicro/stmmac/ring_mode.c | 9 ++-------
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
> 4 files changed, 10 insertions(+), 16 deletions(-)
Here is the summary with links:
- [net-next,1/2] net: stmmac: stmmac_is_jumbo_frm() len should be unsigned
https://git.kernel.org/netdev/net-next/c/b5adada61e02
- [net-next,2/2] net: stmmac: stmmac_is_jumbo_frm() returns boolean
https://git.kernel.org/netdev/net-next/c/bf351bbec57f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-11-19 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 10:00 [PATCH net-next 0/2] net: stmmac: sanitise stmmac_is_jumbo_frm() Russell King (Oracle)
2025-11-18 10:01 ` [PATCH net-next 1/2] net: stmmac: stmmac_is_jumbo_frm() len should be unsigned Russell King (Oracle)
2025-11-18 13:59 ` Maxime Chevallier
2025-11-18 10:01 ` [PATCH net-next 2/2] net: stmmac: stmmac_is_jumbo_frm() returns boolean Russell King (Oracle)
2025-11-18 14:00 ` Maxime Chevallier
2025-11-19 16:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176357041250.873046.17131882776763838281.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).