From: Tariq Toukan <tariqt@nvidia.com>
To: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
Saeed Mahameed <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: [PATCH net-next 03/14] devlink: Add helpers to lock nested-in instances
Date: Thu, 20 Nov 2025 15:09:15 +0200 [thread overview]
Message-ID: <1763644166-1250608-4-git-send-email-tariqt@nvidia.com> (raw)
In-Reply-To: <1763644166-1250608-1-git-send-email-tariqt@nvidia.com>
From: Cosmin Ratiu <cratiu@nvidia.com>
Upcoming code will need to obtain a reference to locked nested-in
devlink instances. Add helpers to lock, obtain an already locked
reference and unlock/unref the nested-in instance.
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
net/devlink/core.c | 42 +++++++++++++++++++++++++++++++++++++
net/devlink/devl_internal.h | 3 +++
2 files changed, 45 insertions(+)
diff --git a/net/devlink/core.c b/net/devlink/core.c
index 6ae62c7f2a80..f228190df346 100644
--- a/net/devlink/core.c
+++ b/net/devlink/core.c
@@ -67,6 +67,48 @@ static void __devlink_rel_put(struct devlink_rel *rel)
devlink_rel_free(rel);
}
+struct devlink *devlink_nested_in_get_lock(struct devlink_rel *rel)
+{
+ struct devlink *devlink;
+
+ if (!rel)
+ return NULL;
+ devlink = devlinks_xa_get(rel->nested_in.devlink_index);
+ if (!devlink)
+ return NULL;
+ devl_lock(devlink);
+ if (devl_is_registered(devlink))
+ return devlink;
+ devl_unlock(devlink);
+ devlink_put(devlink);
+ return NULL;
+}
+
+/* Returns the nested in devlink object and validates its lock is held. */
+struct devlink *devlink_nested_in_get_locked(struct devlink_rel *rel)
+{
+ struct devlink *devlink;
+ unsigned long index;
+
+ if (!rel)
+ return NULL;
+ index = rel->nested_in.devlink_index;
+ devlink = xa_find(&devlinks, &index, index, DEVLINK_REGISTERED);
+ if (devlink)
+ devl_assert_locked(devlink);
+ return devlink;
+}
+
+void devlink_nested_in_put_unlock(struct devlink_rel *rel)
+{
+ struct devlink *devlink = devlink_nested_in_get_locked(rel);
+
+ if (devlink) {
+ devl_unlock(devlink);
+ devlink_put(devlink);
+ }
+}
+
static void devlink_rel_nested_in_notify_work(struct work_struct *work)
{
struct devlink_rel *rel = container_of(work, struct devlink_rel,
diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
index 14eaad9cfe35..aea43d750d23 100644
--- a/net/devlink/devl_internal.h
+++ b/net/devlink/devl_internal.h
@@ -120,6 +120,9 @@ typedef void devlink_rel_notify_cb_t(struct devlink *devlink, u32 obj_index);
typedef void devlink_rel_cleanup_cb_t(struct devlink *devlink, u32 obj_index,
u32 rel_index);
+struct devlink *devlink_nested_in_get_lock(struct devlink_rel *rel);
+struct devlink *devlink_nested_in_get_locked(struct devlink_rel *rel);
+void devlink_nested_in_put_unlock(struct devlink_rel *rel);
void devlink_rel_nested_in_clear(u32 rel_index);
int devlink_rel_nested_in_add(u32 *rel_index, u32 devlink_index,
u32 obj_index, devlink_rel_notify_cb_t *notify_cb,
--
2.31.1
next prev parent reply other threads:[~2025-11-20 13:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 13:09 [PATCH net-next 00/14] devlink and mlx5: Support cross-function rate scheduling Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 01/14] devlink: Reverse locking order for nested instances Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 02/14] documentation: networking: add shared devlink documentation Tariq Toukan
2025-11-20 13:09 ` Tariq Toukan [this message]
2025-11-20 14:52 ` [PATCH net-next 03/14] devlink: Add helpers to lock nested-in instances Jiri Pirko
2025-11-20 13:09 ` [PATCH net-next 04/14] devlink: Refactor devlink_rate_nodes_check Tariq Toukan
2025-11-20 14:53 ` Jiri Pirko
2025-11-20 13:09 ` [PATCH net-next 05/14] devlink: Decouple rate storage from associated devlink object Tariq Toukan
2025-11-20 14:55 ` Jiri Pirko
2025-11-20 13:09 ` [PATCH net-next 06/14] devlink: Add parent dev to devlink API Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 07/14] devlink: Allow parent dev for rate-set and rate-new Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 08/14] devlink: Allow rate node parents from other devlinks Tariq Toukan
2025-11-20 14:55 ` Jiri Pirko
2025-11-20 13:09 ` [PATCH net-next 09/14] net/mlx5: Introduce shared devlink instance for PFs on same chip Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 10/14] net/mlx5: Expose a function to clear a vport's parent Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 11/14] net/mlx5: Store QoS sched nodes in the sh_devlink Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 12/14] net/mlx5: qos: Support cross-device tx scheduling Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 13/14] net/mlx5: qos: Enable cross-device scheduling Tariq Toukan
2025-11-20 13:09 ` [PATCH net-next 14/14] net/mlx5: Document devlink rates Tariq Toukan
2025-11-21 3:39 ` [PATCH net-next 00/14] devlink and mlx5: Support cross-function rate scheduling Jakub Kicinski
2025-11-23 6:57 ` Tariq Toukan
2025-11-25 2:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1763644166-1250608-4-git-send-email-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).