* [PATCH net-next] net: phy: fixed_phy: remove not needed initialization of phy_device members
@ 2025-11-19 6:55 Heiner Kallweit
2025-11-21 2:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2025-11-19 6:55 UTC (permalink / raw)
To: Andrew Lunn, Russell King - ARM Linux, Jakub Kicinski,
Paolo Abeni, Eric Dumazet, David Miller
Cc: netdev@vger.kernel.org
All these members are populated by the phylib state machine once the
PHY has been started, based on the fixed autoneg results.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/fixed_phy.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
index 1ad77f542..cb548740f 100644
--- a/drivers/net/phy/fixed_phy.c
+++ b/drivers/net/phy/fixed_phy.c
@@ -172,13 +172,6 @@ struct phy_device *fixed_phy_register(const struct fixed_phy_status *status,
return ERR_PTR(-EINVAL);
}
- /* propagate the fixed link values to struct phy_device */
- phy->link = 1;
- phy->speed = status->speed;
- phy->duplex = status->duplex;
- phy->pause = status->pause;
- phy->asym_pause = status->asym_pause;
-
of_node_get(np);
phy->mdio.dev.of_node = np;
phy->is_pseudo_fixed_link = true;
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: phy: fixed_phy: remove not needed initialization of phy_device members
2025-11-19 6:55 [PATCH net-next] net: phy: fixed_phy: remove not needed initialization of phy_device members Heiner Kallweit
@ 2025-11-21 2:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-21 2:30 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: andrew, linux, kuba, pabeni, edumazet, davem, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 19 Nov 2025 07:55:47 +0100 you wrote:
> All these members are populated by the phylib state machine once the
> PHY has been started, based on the fixed autoneg results.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/phy/fixed_phy.c | 7 -------
> 1 file changed, 7 deletions(-)
Here is the summary with links:
- [net-next] net: phy: fixed_phy: remove not needed initialization of phy_device members
https://git.kernel.org/netdev/net-next/c/d99b408ed8e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-21 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-19 6:55 [PATCH net-next] net: phy: fixed_phy: remove not needed initialization of phy_device members Heiner Kallweit
2025-11-21 2:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).