* [PATCH net] net: 3com: 3c59x: fix possible null dereference in vortex_probe1()
@ 2026-01-06 9:47 Thomas Fourier
2026-01-08 16:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Fourier @ 2026-01-06 9:47 UTC (permalink / raw)
Cc: Thomas Fourier, stable, Steffen Klassert, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Ingo Molnar, Thomas Gleixner, netdev, linux-kernel
pdev can be null and free_ring: can be called in 1297 with a null
pdev.
Fixes: 55c82617c3e8 ("3c59x: convert to generic DMA API")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
drivers/net/ethernet/3com/3c59x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
index 8c9cc97efd4e..4fe4efdb3737 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -1473,7 +1473,7 @@ static int vortex_probe1(struct device *gendev, void __iomem *ioaddr, int irq,
return 0;
free_ring:
- dma_free_coherent(&pdev->dev,
+ dma_free_coherent(gendev,
sizeof(struct boom_rx_desc) * RX_RING_SIZE +
sizeof(struct boom_tx_desc) * TX_RING_SIZE,
vp->rx_ring, vp->rx_ring_dma);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: 3com: 3c59x: fix possible null dereference in vortex_probe1()
2026-01-06 9:47 [PATCH net] net: 3com: 3c59x: fix possible null dereference in vortex_probe1() Thomas Fourier
@ 2026-01-08 16:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-08 16:40 UTC (permalink / raw)
To: Thomas Fourier
Cc: stable, klassert, andrew+netdev, davem, edumazet, kuba, pabeni,
mingo, tglx, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 6 Jan 2026 10:47:21 +0100 you wrote:
> pdev can be null and free_ring: can be called in 1297 with a null
> pdev.
>
> Fixes: 55c82617c3e8 ("3c59x: convert to generic DMA API")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: 3com: 3c59x: fix possible null dereference in vortex_probe1()
https://git.kernel.org/netdev/net/c/a4e305ed60f7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-08 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-06 9:47 [PATCH net] net: 3com: 3c59x: fix possible null dereference in vortex_probe1() Thomas Fourier
2026-01-08 16:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox