* [PATCH net] tools: ynl: don't install tests
@ 2026-01-06 16:34 Jakub Kicinski
2026-01-07 1:43 ` Hangbin Liu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jakub Kicinski @ 2026-01-06 16:34 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
donald.hunter, jstancek, liuhangbin, matttbe
make's install target is meant for installing the production
artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool
from under the main YNL install target. The install target
under tests/ is retained in case someone wants the tests
to be installed.
Fixes: 308b7dee3e5c ("tools: ynl: add YNL test framework")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: donald.hunter@gmail.com
CC: jstancek@redhat.com
CC: liuhangbin@gmail.com
CC: matttbe@kernel.org
---
tools/net/ynl/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
index 7736b492f559..c2f3e8b3f2ac 100644
--- a/tools/net/ynl/Makefile
+++ b/tools/net/ynl/Makefile
@@ -51,7 +51,6 @@ install: libynl.a lib/*.h
@echo -e "\tINSTALL pyynl"
@pip install --prefix=$(DESTDIR)$(prefix) .
@make -C generated install
- @make -C tests install
run_tests:
@$(MAKE) -C tests run_tests
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] tools: ynl: don't install tests
2026-01-06 16:34 [PATCH net] tools: ynl: don't install tests Jakub Kicinski
@ 2026-01-07 1:43 ` Hangbin Liu
2026-01-07 10:36 ` Donald Hunter
2026-01-08 16:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Hangbin Liu @ 2026-01-07 1:43 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
donald.hunter, jstancek, matttbe
On Tue, Jan 06, 2026 at 08:34:26AM -0800, Jakub Kicinski wrote:
> make's install target is meant for installing the production
> artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool
> from under the main YNL install target. The install target
> under tests/ is retained in case someone wants the tests
> to be installed.
>
> Fixes: 308b7dee3e5c ("tools: ynl: add YNL test framework")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jstancek@redhat.com
> CC: liuhangbin@gmail.com
> CC: matttbe@kernel.org
> ---
> tools/net/ynl/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
> index 7736b492f559..c2f3e8b3f2ac 100644
> --- a/tools/net/ynl/Makefile
> +++ b/tools/net/ynl/Makefile
> @@ -51,7 +51,6 @@ install: libynl.a lib/*.h
> @echo -e "\tINSTALL pyynl"
> @pip install --prefix=$(DESTDIR)$(prefix) .
> @make -C generated install
> - @make -C tests install
>
> run_tests:
> @$(MAKE) -C tests run_tests
> --
> 2.52.0
>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] tools: ynl: don't install tests
2026-01-06 16:34 [PATCH net] tools: ynl: don't install tests Jakub Kicinski
2026-01-07 1:43 ` Hangbin Liu
@ 2026-01-07 10:36 ` Donald Hunter
2026-01-08 16:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Donald Hunter @ 2026-01-07 10:36 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms, jstancek,
liuhangbin, matttbe
Jakub Kicinski <kuba@kernel.org> writes:
> make's install target is meant for installing the production
> artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool
> from under the main YNL install target. The install target
> under tests/ is retained in case someone wants the tests
> to be installed.
>
> Fixes: 308b7dee3e5c ("tools: ynl: add YNL test framework")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: donald.hunter@gmail.com
> CC: jstancek@redhat.com
> CC: liuhangbin@gmail.com
> CC: matttbe@kernel.org
> ---
> tools/net/ynl/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/net/ynl/Makefile b/tools/net/ynl/Makefile
> index 7736b492f559..c2f3e8b3f2ac 100644
> --- a/tools/net/ynl/Makefile
> +++ b/tools/net/ynl/Makefile
> @@ -51,7 +51,6 @@ install: libynl.a lib/*.h
> @echo -e "\tINSTALL pyynl"
> @pip install --prefix=$(DESTDIR)$(prefix) .
> @make -C generated install
> - @make -C tests install
>
> run_tests:
> @$(MAKE) -C tests run_tests
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] tools: ynl: don't install tests
2026-01-06 16:34 [PATCH net] tools: ynl: don't install tests Jakub Kicinski
2026-01-07 1:43 ` Hangbin Liu
2026-01-07 10:36 ` Donald Hunter
@ 2026-01-08 16:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-08 16:50 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
donald.hunter, jstancek, liuhangbin, matttbe
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 6 Jan 2026 08:34:26 -0800 you wrote:
> make's install target is meant for installing the production
> artifacts, AFAIU. Don't install test_ynl_cli and test_ynl_ethtool
> from under the main YNL install target. The install target
> under tests/ is retained in case someone wants the tests
> to be installed.
>
> Fixes: 308b7dee3e5c ("tools: ynl: add YNL test framework")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net] tools: ynl: don't install tests
https://git.kernel.org/netdev/net/c/790792ebc960
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-08 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-06 16:34 [PATCH net] tools: ynl: don't install tests Jakub Kicinski
2026-01-07 1:43 ` Hangbin Liu
2026-01-07 10:36 ` Donald Hunter
2026-01-08 16:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox