[PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[Frank Li]

Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
description to set SPI mode") required both 'default' and 'reset' pinctrl
states for all compatible devices. However, this requirement should be only
applicable to KSZ8463.

Make the 'reset' pinctrl state optional for all other Microchip DSA
devices while keeping it mandatory for KSZ8463.

Fix below CHECK_DTBS warnings:
  arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
index a8c8009414ae0..8d4a3a9a33fcc 100644
--- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
@@ -40,6 +40,7 @@ properties:
       - const: reset
         description:
           Used during reset for strap configuration.
+    minItems: 1
 
   reset-gpios:
     description:
@@ -153,6 +154,8 @@ allOf:
             const: microchip,ksz8463
     then:
       properties:
+        pinctrl-names:
+          minItems: 2
         straps-rxd-gpios:
           description:
             RXD0 and RXD1 pins, used to select SPI as bus interface.
-- 
2.34.1

Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[Marco Felsch]

Hi Frank,

thanks for fixing this.

On 26-01-06, Frank Li wrote:
> Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> description to set SPI mode") required both 'default' and 'reset' pinctrl
> states for all compatible devices. However, this requirement should be only
> applicable to KSZ8463.
> 
> Make the 'reset' pinctrl state optional for all other Microchip DSA
> devices while keeping it mandatory for KSZ8463.
> 
> Fix below CHECK_DTBS warnings:
>   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
> 

Fixes tag?

> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index a8c8009414ae0..8d4a3a9a33fcc 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> @@ -40,6 +40,7 @@ properties:
>        - const: reset
>          description:
>            Used during reset for strap configuration.
> +    minItems: 1

Does this mean that all others can now either specify 'reset' or
'default'? If yes, this seems wrong.

Regards,
  Marco

>  
>    reset-gpios:
>      description:
> @@ -153,6 +154,8 @@ allOf:
>              const: microchip,ksz8463
>      then:
>        properties:
> +        pinctrl-names:
> +          minItems: 2
>          straps-rxd-gpios:
>            description:
>              RXD0 and RXD1 pins, used to select SPI as bus interface.
> -- 
> 2.34.1
> 
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[Frank Li]

On Tue, Jan 06, 2026 at 04:02:45PM +0100, Marco Felsch wrote:
> Hi Frank,
>
> thanks for fixing this.
>
> On 26-01-06, Frank Li wrote:
> > Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> > description to set SPI mode") required both 'default' and 'reset' pinctrl
> > states for all compatible devices. However, this requirement should be only
> > applicable to KSZ8463.
> >
> > Make the 'reset' pinctrl state optional for all other Microchip DSA
> > devices while keeping it mandatory for KSZ8463.
> >
> > Fix below CHECK_DTBS warnings:
> >   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> > 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
> >
>
> Fixes tag?

This one is only fix warning, some maintainer wants add fixes tags only for
user visualable issue.

If maintainer want, it can be added when apply, commit hash already in
commit message.

>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > index a8c8009414ae0..8d4a3a9a33fcc 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > @@ -40,6 +40,7 @@ properties:
> >        - const: reset
> >          description:
> >            Used during reset for strap configuration.
> > +    minItems: 1
>
> Does this mean that all others can now either specify 'reset' or
> 'default'? If yes, this seems wrong.

No,  It allow that
	 case 1: "default"
	 case 2: "default", "reset".

Don't allow 'reset' only.

Frank

>
> Regards,
>   Marco
>
> >
> >    reset-gpios:
> >      description:
> > @@ -153,6 +154,8 @@ allOf:
> >              const: microchip,ksz8463
> >      then:
> >        properties:
> > +        pinctrl-names:
> > +          minItems: 2
> >          straps-rxd-gpios:
> >            description:
> >              RXD0 and RXD1 pins, used to select SPI as bus interface.
> > --
> > 2.34.1
> >
> >
>
> --
> #gernperDu
> #CallMeByMyFirstName
>
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[Marco Felsch]

On 26-01-06, Frank Li wrote:
> On Tue, Jan 06, 2026 at 04:02:45PM +0100, Marco Felsch wrote:
> > Hi Frank,
> >
> > thanks for fixing this.
> >
> > On 26-01-06, Frank Li wrote:
> > > Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> > > description to set SPI mode") required both 'default' and 'reset' pinctrl
> > > states for all compatible devices. However, this requirement should be only
> > > applicable to KSZ8463.
> > >
> > > Make the 'reset' pinctrl state optional for all other Microchip DSA
> > > devices while keeping it mandatory for KSZ8463.
> > >
> > > Fix below CHECK_DTBS warnings:
> > >   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> > > 	from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
> > >
> >
> > Fixes tag?
> 
> This one is only fix warning, some maintainer wants add fixes tags only for
> user visualable issue.
> 
> If maintainer want, it can be added when apply, commit hash already in
> commit message.
> 
> >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > index a8c8009414ae0..8d4a3a9a33fcc 100644
> > > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > @@ -40,6 +40,7 @@ properties:
> > >        - const: reset
> > >          description:
> > >            Used during reset for strap configuration.
> > > +    minItems: 1
> >
> > Does this mean that all others can now either specify 'reset' or
> > 'default'? If yes, this seems wrong.
> 
> No,  It allow that
> 	 case 1: "default"
> 	 case 2: "default", "reset".
> 
> Don't allow 'reset' only.

Ah okay, so it takes the list element-pos. into account, fingers
crossed, that no one is going to change the order :-)

Thanks for the info, with that:

Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

> 
> Frank
> 
> >
> > Regards,
> >   Marco
> >
> > >
> > >    reset-gpios:
> > >      description:
> > > @@ -153,6 +154,8 @@ allOf:
> > >              const: microchip,ksz8463
> > >      then:
> > >        properties:
> > > +        pinctrl-names:
> > > +          minItems: 2
> > >          straps-rxd-gpios:
> > >            description:
> > >              RXD0 and RXD1 pins, used to select SPI as bus interface.
> > > --
> > > 2.34.1
> > >
> > >
> >
> > --
> > #gernperDu
> > #CallMeByMyFirstName
> >
> > Pengutronix e.K.                           |                             |
> > Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
> > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[Rob Herring]

On Tue, Jan 6, 2026 at 8:36 AM Frank Li <Frank.Li@nxp.com> wrote:
>
> Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> description to set SPI mode") required both 'default' and 'reset' pinctrl
> states for all compatible devices. However, this requirement should be only
> applicable to KSZ8463.
>
> Make the 'reset' pinctrl state optional for all other Microchip DSA
> devices while keeping it mandatory for KSZ8463.
>
> Fix below CHECK_DTBS warnings:
>   arch/arm64/boot/dts/freescale/imx8mp-skov-basic.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
>         from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  6 Jan 2026 09:36:19 -0500 you wrote:
> Commit e469b87e0fb0d ("dt-bindings: net: dsa: microchip: Add strap
> description to set SPI mode") required both 'default' and 'reset' pinctrl
> states for all compatible devices. However, this requirement should be only
> applicable to KSZ8463.
> 
> Make the 'reset' pinctrl state optional for all other Microchip DSA
> devices while keeping it mandatory for KSZ8463.
> 
> [...]

Here is the summary with links:
  - [1/1] dt-bindings: net: dsa: microchip: Make pinctrl 'reset' optional
    https://git.kernel.org/netdev/net-next/c/f56bcc0425cb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html