From: Tariq Toukan <tariqt@nvidia.com>
To: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: Jian Shen <shenjian15@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Jijie Shao <shaojijie@huawei.com>,
Saeed Mahameed <saeedm@nvidia.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, Gal Pressman <gal@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>,
Shahar Shitrit <shshitrit@nvidia.com>,
Yael Chemla <ychemla@nvidia.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: [PATCH net-next V2 0/3] Introduce and use netif_xmit_timeout_ms() helper
Date: Mon, 12 Jan 2026 11:16:20 +0200 [thread overview]
Message-ID: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> (raw)
Hi,
This is V2, find V1 here:
https://lore.kernel.org/all/1764054776-1308696-1-git-send-email-tariqt@nvidia.com/
This series by Shahar introduces a new helper function
netif_xmit_timeout_ms() to check if a TX queue has timed out and report
the timeout duration.
It also encapsulates the check for whether the TX queue is stopped.
Replace duplicated open-coded timeout check in hns3 driver with the new
helper.
For mlx5e, refine the TX timeout recovery flow to act only on SQs whose
transmit timestamp indicates an actual timeout, as determined by the
helper. This prevents unnecessary channel reopen events caused by
attempting recovery on queues that are merely stopped but not truly
timed out.
Regards,
Tariq
V2:
- Rebase.
- Move helper to include/net/netdev_queues.h.
- Remove output paramter trans_start from the new helper.
- Revert the code in dev_watchdog to not use the helper.
- Fix the helper name in commit message.
Shahar Shitrit (3):
net: Introduce netif_xmit_timeout_ms() helper
net: hns3: Use netif_xmit_timeout_ms() helper
net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 +++++-------
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
include/net/netdev_queues.h | 11 +++++++++++
3 files changed, 17 insertions(+), 8 deletions(-)
base-commit: 60d8484c4cec811f5ceb6550655df74490d1a165
--
2.31.1
next reply other threads:[~2026-01-12 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 9:16 Tariq Toukan [this message]
2026-01-12 9:16 ` [PATCH net-next V2 1/3] net: Introduce netif_xmit_timeout_ms() helper Tariq Toukan
2026-01-12 9:16 ` [PATCH net-next V2 2/3] net: hns3: Use " Tariq Toukan
2026-01-12 11:22 ` Jijie Shao
2026-01-12 9:16 ` [PATCH net-next V2 3/3] net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ Tariq Toukan
2026-01-14 9:18 ` [PATCH net-next V2 0/3] Introduce and use netif_xmit_timeout_ms() helper Simon Horman
2026-01-15 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1768209383-1546791-1-git-send-email-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shshitrit@nvidia.com \
--cc=ychemla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox