* [PATCH net v2] vsock/test: add a final full barrier after run all tests
@ 2026-01-08 11:44 Stefano Garzarella
2026-01-12 20:56 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Garzarella @ 2026-01-08 11:44 UTC (permalink / raw)
To: netdev
Cc: virtualization, David S. Miller, Stefan Hajnoczi, linux-kernel,
Stefano Garzarella, Luigi Leonardi
From: Stefano Garzarella <sgarzare@redhat.com>
If the last test fails, the other side still completes correctly,
which could lead to false positives.
Let's add a final barrier that ensures that the last test has finished
correctly on both sides, but also that the two sides agree on the
number of tests to be performed.
Fixes: 2f65b44e199c ("VSOCK: add full barrier between test cases")
Reviewed-by: Luigi Leonardi <leonardi@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
v2:
- code unchanged from v1
- target net tree and add fixes tag [Paolo]
- added Luigi's R-b
v1: https://lore.kernel.org/netdev/20251223162210.43976-1-sgarzare@redhat.com/
---
tools/testing/vsock/util.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c
index d843643ced6b..9430ef5b8bc3 100644
--- a/tools/testing/vsock/util.c
+++ b/tools/testing/vsock/util.c
@@ -511,6 +511,18 @@ void run_tests(const struct test_case *test_cases,
printf("ok\n");
}
+
+ printf("All tests have been executed. Waiting other peer...");
+ fflush(stdout);
+
+ /*
+ * Final full barrier, to ensure that all tests have been run and
+ * that even the last one has been successful on both sides.
+ */
+ control_writeln("COMPLETED");
+ control_expectln("COMPLETED");
+
+ printf("ok\n");
}
void list_tests(const struct test_case *test_cases)
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net v2] vsock/test: add a final full barrier after run all tests
2026-01-08 11:44 [PATCH net v2] vsock/test: add a final full barrier after run all tests Stefano Garzarella
@ 2026-01-12 20:56 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-12 20:56 UTC (permalink / raw)
To: Stefano Garzarella
Cc: netdev, virtualization, davem, stefanha, linux-kernel, leonardi
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 8 Jan 2026 12:44:19 +0100 you wrote:
> From: Stefano Garzarella <sgarzare@redhat.com>
>
> If the last test fails, the other side still completes correctly,
> which could lead to false positives.
>
> Let's add a final barrier that ensures that the last test has finished
> correctly on both sides, but also that the two sides agree on the
> number of tests to be performed.
>
> [...]
Here is the summary with links:
- [net,v2] vsock/test: add a final full barrier after run all tests
https://git.kernel.org/netdev/net/c/c39a6a277e0e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-12 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 11:44 [PATCH net v2] vsock/test: add a final full barrier after run all tests Stefano Garzarella
2026-01-12 20:56 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox