* [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message
@ 2026-01-09 10:39 Kunihiko Hayashi
2026-01-09 18:41 ` Andrew Lunn
2026-01-12 20:57 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Kunihiko Hayashi @ 2026-01-09 10:39 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: netdev, linux-kernel, Kunihiko Hayashi
Follow the warning from checkpatch.pl and remove 'out of memory' message.
WARNING: Possible unnecessary 'out of memory' message
#590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
+ if (!skb) {
+ netdev_err(ndev, "can't allocate skb for Rx\n");
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
drivers/net/ethernet/socionext/sni_ave.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
index 66b3549636f8..4700998c4837 100644
--- a/drivers/net/ethernet/socionext/sni_ave.c
+++ b/drivers/net/ethernet/socionext/sni_ave.c
@@ -586,10 +586,8 @@ static int ave_rxdesc_prepare(struct net_device *ndev, int entry)
skb = priv->rx.desc[entry].skbs;
if (!skb) {
skb = netdev_alloc_skb(ndev, AVE_MAX_ETHFRAME);
- if (!skb) {
- netdev_err(ndev, "can't allocate skb for Rx\n");
+ if (!skb)
return -ENOMEM;
- }
skb->data += AVE_FRAME_HEADROOM;
skb->tail += AVE_FRAME_HEADROOM;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message
2026-01-09 10:39 [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message Kunihiko Hayashi
@ 2026-01-09 18:41 ` Andrew Lunn
2026-01-12 20:57 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2026-01-09 18:41 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel
On Fri, Jan 09, 2026 at 07:39:15PM +0900, Kunihiko Hayashi wrote:
> Follow the warning from checkpatch.pl and remove 'out of memory' message.
>
> WARNING: Possible unnecessary 'out of memory' message
> #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
> + if (!skb) {
> + netdev_err(ndev, "can't allocate skb for Rx\n");
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message
2026-01-09 10:39 [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message Kunihiko Hayashi
2026-01-09 18:41 ` Andrew Lunn
@ 2026-01-12 20:57 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-12 20:57 UTC (permalink / raw)
To: Kunihiko Hayashi
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 9 Jan 2026 19:39:15 +0900 you wrote:
> Follow the warning from checkpatch.pl and remove 'out of memory' message.
>
> WARNING: Possible unnecessary 'out of memory' message
> #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
> + if (!skb) {
> + netdev_err(ndev, "can't allocate skb for Rx\n");
>
> [...]
Here is the summary with links:
- [RESEND,net-next,v1] net: ethernet: ave: Remove unnecessary 'out of memory' message
https://git.kernel.org/netdev/net-next/c/11ed2195887d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-12 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 10:39 [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message Kunihiko Hayashi
2026-01-09 18:41 ` Andrew Lunn
2026-01-12 20:57 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox