public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN
@ 2026-01-07  9:18 Mark Bloch
  2026-01-07  9:18 ` [PATCH net-next 1/3] net/mlx5e: TSO for GRE over vlan Mark Bloch
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Mark Bloch @ 2026-01-07  9:18 UTC (permalink / raw)
  To: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn,
	David S. Miller
  Cc: Saeed Mahameed, Tariq Toukan, Mark Bloch, Leon Romanovsky, netdev,
	linux-rdma, linux-kernel, Gal Pressman

Hi,

The following 3 small patches by Gal add support for TSO for
UDP over GRE over VLAN packets.

Gal Pressman (3):
  net/mlx5e: TSO for GRE over vlan
  net/mlx5e: TSO for UDP over GRE over vlan packets
  net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE

 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: 956f569c90ab507559342d289f4c923adfbf06f5
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next 1/3] net/mlx5e: TSO for GRE over vlan
  2026-01-07  9:18 [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN Mark Bloch
@ 2026-01-07  9:18 ` Mark Bloch
  2026-01-07  9:18 ` [PATCH net-next 2/3] net/mlx5e: TSO for UDP over GRE over vlan packets Mark Bloch
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Mark Bloch @ 2026-01-07  9:18 UTC (permalink / raw)
  To: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn,
	David S. Miller
  Cc: Saeed Mahameed, Tariq Toukan, Mark Bloch, Leon Romanovsky, netdev,
	linux-rdma, linux-kernel, Gal Pressman, Cosmin Ratiu

From: Gal Pressman <gal@nvidia.com>

The hardware supports segmentation offload of GRE tunnel over vlan,
allow it by adding it to vlan_features.

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 07fc4d2c8fad..1734c4dd1d0f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -5800,6 +5800,7 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev)
 					   NETIF_F_GSO_GRE_CSUM;
 		netdev->gso_partial_features |= NETIF_F_GSO_GRE |
 						NETIF_F_GSO_GRE_CSUM;
+		netdev->vlan_features |= NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM;
 	}
 
 	if (mlx5e_tunnel_proto_supported_tx(mdev, IPPROTO_IPIP)) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH net-next 2/3] net/mlx5e: TSO for UDP over GRE over vlan packets
  2026-01-07  9:18 [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN Mark Bloch
  2026-01-07  9:18 ` [PATCH net-next 1/3] net/mlx5e: TSO for GRE over vlan Mark Bloch
@ 2026-01-07  9:18 ` Mark Bloch
  2026-01-07  9:18 ` [PATCH net-next 3/3] net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE Mark Bloch
  2026-01-12 20:57 ` [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: Mark Bloch @ 2026-01-07  9:18 UTC (permalink / raw)
  To: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn,
	David S. Miller
  Cc: Saeed Mahameed, Tariq Toukan, Mark Bloch, Leon Romanovsky, netdev,
	linux-rdma, linux-kernel, Gal Pressman, Cosmin Ratiu

From: Gal Pressman <gal@nvidia.com>

The hardware supports segmentation offload of UDP over GRE over vlan
packets, allow it by adding NETIF_F_GSO_UDP_L4 to hw_enc_features which
will make the vlan device inherit it to its own hw_enc_features.

Side note: it is quite confusing that this change wasn't needed to
offload encapsulated UDP packets regardless of vlan, but that's the way
that the stack handles gso partial features, it assumes they're
supported without caring if the feature is supported in hw_enc_features.

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index 1734c4dd1d0f..ce71a03a9b71 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -5814,6 +5814,7 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev)
 
 	netdev->gso_partial_features             |= NETIF_F_GSO_UDP_L4;
 	netdev->hw_features                      |= NETIF_F_GSO_UDP_L4;
+	netdev->hw_enc_features                  |= NETIF_F_GSO_UDP_L4;
 
 	mlx5_query_port_fcs(mdev, &fcs_supported, &fcs_enabled);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH net-next 3/3] net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE
  2026-01-07  9:18 [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN Mark Bloch
  2026-01-07  9:18 ` [PATCH net-next 1/3] net/mlx5e: TSO for GRE over vlan Mark Bloch
  2026-01-07  9:18 ` [PATCH net-next 2/3] net/mlx5e: TSO for UDP over GRE over vlan packets Mark Bloch
@ 2026-01-07  9:18 ` Mark Bloch
  2026-01-12 20:57 ` [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: Mark Bloch @ 2026-01-07  9:18 UTC (permalink / raw)
  To: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn,
	David S. Miller
  Cc: Saeed Mahameed, Tariq Toukan, Mark Bloch, Leon Romanovsky, netdev,
	linux-rdma, linux-kernel, Gal Pressman, Dragos Tatulea

From: Gal Pressman <gal@nvidia.com>

The hardware can do TSO for GRE packets without an outer checksum, it
doesn't need GSO_PARTIAL's help.

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index ce71a03a9b71..3ac47df83ac8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -5798,8 +5798,7 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev)
 					   NETIF_F_GSO_GRE_CSUM;
 		netdev->hw_enc_features |= NETIF_F_GSO_GRE |
 					   NETIF_F_GSO_GRE_CSUM;
-		netdev->gso_partial_features |= NETIF_F_GSO_GRE |
-						NETIF_F_GSO_GRE_CSUM;
+		netdev->gso_partial_features |= NETIF_F_GSO_GRE_CSUM;
 		netdev->vlan_features |= NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM;
 	}
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN
  2026-01-07  9:18 [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN Mark Bloch
                   ` (2 preceding siblings ...)
  2026-01-07  9:18 ` [PATCH net-next 3/3] net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE Mark Bloch
@ 2026-01-12 20:57 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-12 20:57 UTC (permalink / raw)
  To: Mark Bloch
  Cc: edumazet, kuba, pabeni, andrew+netdev, davem, saeedm, tariqt,
	leon, netdev, linux-rdma, linux-kernel, gal

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 7 Jan 2026 11:18:45 +0200 you wrote:
> Hi,
> 
> The following 3 small patches by Gal add support for TSO for
> UDP over GRE over VLAN packets.
> 
> Gal Pressman (3):
>   net/mlx5e: TSO for GRE over vlan
>   net/mlx5e: TSO for UDP over GRE over vlan packets
>   net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net/mlx5e: TSO for GRE over vlan
    https://git.kernel.org/netdev/net-next/c/6e6c751b41a8
  - [net-next,2/3] net/mlx5e: TSO for UDP over GRE over vlan packets
    https://git.kernel.org/netdev/net-next/c/5f410e1224e4
  - [net-next,3/3] net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE
    https://git.kernel.org/netdev/net-next/c/b30ba673058d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-12 21:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07  9:18 [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN Mark Bloch
2026-01-07  9:18 ` [PATCH net-next 1/3] net/mlx5e: TSO for GRE over vlan Mark Bloch
2026-01-07  9:18 ` [PATCH net-next 2/3] net/mlx5e: TSO for UDP over GRE over vlan packets Mark Bloch
2026-01-07  9:18 ` [PATCH net-next 3/3] net/mlx5e: Remove GSO_PARTIAL for non _CSUM GRE Mark Bloch
2026-01-12 20:57 ` [PATCH net-next 0/3] mlx5: Add TSO support for UDP over GRE over VLAN patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox