public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] net: phy: motorcomm: fix duplex setting error for phy leds
@ 2026-01-08  7:14 Jijie Shao
  2026-01-08 18:33 ` Andrew Lunn
  2026-01-13  3:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jijie Shao @ 2026-01-08  7:14 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, andrew+netdev, horms, Frank.Sae,
	hkallweit1, linux
  Cc: shenjian15, liuyonglong, chenhao418, jonathan.cameron,
	salil.mehta, shiyongbang, netdev, linux-kernel, shaojijie

fix duplex setting error for phy leds

Fixes: 355b82c54c12 ("net: phy: motorcomm: Add support for PHY LEDs on YT8521")
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
---
 drivers/net/phy/motorcomm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 89b5b19a9bd2..42d46b5758fc 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -1741,10 +1741,10 @@ static int yt8521_led_hw_control_set(struct phy_device *phydev, u8 index,
 		val |= YT8521_LED_1000_ON_EN;
 
 	if (test_bit(TRIGGER_NETDEV_FULL_DUPLEX, &rules))
-		val |= YT8521_LED_HDX_ON_EN;
+		val |= YT8521_LED_FDX_ON_EN;
 
 	if (test_bit(TRIGGER_NETDEV_HALF_DUPLEX, &rules))
-		val |= YT8521_LED_FDX_ON_EN;
+		val |= YT8521_LED_HDX_ON_EN;
 
 	if (test_bit(TRIGGER_NETDEV_TX, &rules) ||
 	    test_bit(TRIGGER_NETDEV_RX, &rules))
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net: phy: motorcomm: fix duplex setting error for phy leds
  2026-01-08  7:14 [PATCH net] net: phy: motorcomm: fix duplex setting error for phy leds Jijie Shao
@ 2026-01-08 18:33 ` Andrew Lunn
  2026-01-13  3:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2026-01-08 18:33 UTC (permalink / raw)
  To: Jijie Shao
  Cc: davem, edumazet, kuba, pabeni, andrew+netdev, horms, Frank.Sae,
	hkallweit1, linux, shenjian15, liuyonglong, chenhao418,
	jonathan.cameron, salil.mehta, shiyongbang, netdev, linux-kernel

On Thu, Jan 08, 2026 at 03:14:09PM +0800, Jijie Shao wrote:
> fix duplex setting error for phy leds
> 
> Fixes: 355b82c54c12 ("net: phy: motorcomm: Add support for PHY LEDs on YT8521")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net: phy: motorcomm: fix duplex setting error for phy leds
  2026-01-08  7:14 [PATCH net] net: phy: motorcomm: fix duplex setting error for phy leds Jijie Shao
  2026-01-08 18:33 ` Andrew Lunn
@ 2026-01-13  3:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-13  3:00 UTC (permalink / raw)
  To: Jijie Shao
  Cc: davem, edumazet, kuba, pabeni, andrew+netdev, horms, Frank.Sae,
	hkallweit1, linux, shenjian15, liuyonglong, chenhao418,
	jonathan.cameron, salil.mehta, shiyongbang, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 8 Jan 2026 15:14:09 +0800 you wrote:
> fix duplex setting error for phy leds
> 
> Fixes: 355b82c54c12 ("net: phy: motorcomm: Add support for PHY LEDs on YT8521")
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
>  drivers/net/phy/motorcomm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [net] net: phy: motorcomm: fix duplex setting error for phy leds
    https://git.kernel.org/netdev/net/c/e02f2a0f1f9b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-13  3:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08  7:14 [PATCH net] net: phy: motorcomm: fix duplex setting error for phy leds Jijie Shao
2026-01-08 18:33 ` Andrew Lunn
2026-01-13  3:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox