[PATCH net-next] net: add kdoc for napi_consume_skb()

[PATCH net-next] net: add kdoc for napi_consume_skb()

[Jakub Kicinski]

Looks like AI reviewers miss that napi_consume_skb() must have
a real budget passed to it. Let's see if adding a real kdoc will
help them figure this out.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: kernelxing@tencent.com
---
 net/core/skbuff.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index c29677f7857c..3fa01cc90613 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1499,9 +1499,20 @@ void napi_skb_free_stolen_head(struct sk_buff *skb)
 	napi_skb_cache_put(skb);
 }
 
+/**
+ * napi_consume_skb() - consume skb in NAPI context, try to feed skb cache
+ * @skb: buffer to free
+ * @budget: NAPI budget
+ *
+ * Non-zero @budget must come from the @budget argument passed by the core
+ * to a NAPI poll function. Note that core may pass budget of 0 to NAPI poll
+ * for example when polling for netpoll / netconsole.
+ *
+ * Passing @budget of 0 is safe from any context, it turns this function
+ * into dev_consume_skb_any().
+ */
 void napi_consume_skb(struct sk_buff *skb, int budget)
 {
-	/* Zero budget indicate non-NAPI context called us, like netpoll */
 	if (unlikely(!budget || !skb)) {
 		dev_consume_skb_any(skb);
 		return;
-- 
2.52.0

Re: [PATCH net-next] net: add kdoc for napi_consume_skb()

[Jason Xing]

On Tue, Jan 20, 2026 at 6:41 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Looks like AI reviewers miss that napi_consume_skb() must have
> a real budget passed to it. Let's see if adding a real kdoc will
> help them figure this out.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

It does make sense if we add more useful comments like this to help AI
review examine the patches on the mailing list.

Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>

Thanks,
Jason

Re: [PATCH net-next] net: add kdoc for napi_consume_skb()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 19 Jan 2026 14:41:40 -0800 you wrote:
> Looks like AI reviewers miss that napi_consume_skb() must have
> a real budget passed to it. Let's see if adding a real kdoc will
> help them figure this out.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kernelxing@tencent.com
> 
> [...]

Here is the summary with links:
  - [net-next] net: add kdoc for napi_consume_skb()
    https://git.kernel.org/netdev/net-next/c/cd18e8ac030e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html