* [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
2026-01-07 6:57 [PATCH net-next] net: usb: introduce usbnet_mii_ioctl helper function Ethan Nelson-Moore
@ 2026-01-07 6:57 ` Ethan Nelson-Moore
2026-01-07 17:39 ` Andrew Lunn
0 siblings, 1 reply; 5+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-07 6:57 UTC (permalink / raw)
To: netdev; +Cc: Ethan Nelson-Moore
The smsc95xx_ioctl function behaves identically to the
phy_do_ioctl_running function. Remove it and use the
phy_do_ioctl_running function directly instead.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/usb/smsc95xx.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index de733e0488bf..c65402d850c9 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -854,14 +854,6 @@ static const struct ethtool_ops smsc95xx_ethtool_ops = {
.set_pauseparam = smsc95xx_set_pauseparam,
};
-static int smsc95xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
-{
- if (!netif_running(netdev))
- return -EINVAL;
-
- return phy_mii_ioctl(netdev->phydev, rq, cmd);
-}
-
static void smsc95xx_init_mac_address(struct usbnet *dev)
{
u8 addr[ETH_ALEN];
@@ -1139,7 +1131,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = {
.ndo_get_stats64 = dev_get_tstats64,
.ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
- .ndo_eth_ioctl = smsc95xx_ioctl,
+ .ndo_eth_ioctl = phy_do_ioctl_running,
.ndo_set_rx_mode = smsc95xx_set_multicast,
.ndo_set_features = smsc95xx_set_features,
};
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
2026-01-07 6:57 ` [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Ethan Nelson-Moore
@ 2026-01-07 17:39 ` Andrew Lunn
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2026-01-07 17:39 UTC (permalink / raw)
To: Ethan Nelson-Moore; +Cc: netdev
On Tue, Jan 06, 2026 at 10:57:49PM -0800, Ethan Nelson-Moore wrote:
> The smsc95xx_ioctl function behaves identically to the
> phy_do_ioctl_running function. Remove it and use the
> phy_do_ioctl_running function directly instead.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
@ 2026-01-24 8:07 Ethan Nelson-Moore
2026-01-24 18:49 ` Andrew Lunn
2026-01-27 3:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-24 8:07 UTC (permalink / raw)
To: netdev, linux-usb
Cc: Ethan Nelson-Moore, Steve Glendinning, UNGLinuxDriver,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
The smsc95xx_ioctl function behaves identically to the
phy_do_ioctl_running function. Remove it and use the
phy_do_ioctl_running function directly instead.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/usb/smsc95xx.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index de733e0488bf..c65402d850c9 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -854,14 +854,6 @@ static const struct ethtool_ops smsc95xx_ethtool_ops = {
.set_pauseparam = smsc95xx_set_pauseparam,
};
-static int smsc95xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
-{
- if (!netif_running(netdev))
- return -EINVAL;
-
- return phy_mii_ioctl(netdev->phydev, rq, cmd);
-}
-
static void smsc95xx_init_mac_address(struct usbnet *dev)
{
u8 addr[ETH_ALEN];
@@ -1139,7 +1131,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = {
.ndo_get_stats64 = dev_get_tstats64,
.ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
- .ndo_eth_ioctl = smsc95xx_ioctl,
+ .ndo_eth_ioctl = phy_do_ioctl_running,
.ndo_set_rx_mode = smsc95xx_set_multicast,
.ndo_set_features = smsc95xx_set_features,
};
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
2026-01-24 8:07 [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Ethan Nelson-Moore
@ 2026-01-24 18:49 ` Andrew Lunn
2026-01-27 3:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2026-01-24 18:49 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: netdev, linux-usb, Steve Glendinning, UNGLinuxDriver, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Sat, Jan 24, 2026 at 12:07:51AM -0800, Ethan Nelson-Moore wrote:
> The smsc95xx_ioctl function behaves identically to the
> phy_do_ioctl_running function. Remove it and use the
> phy_do_ioctl_running function directly instead.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
2026-01-24 8:07 [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Ethan Nelson-Moore
2026-01-24 18:49 ` Andrew Lunn
@ 2026-01-27 3:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-27 3:40 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: netdev, linux-usb, steve.glendinning, UNGLinuxDriver,
andrew+netdev, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 24 Jan 2026 00:07:51 -0800 you wrote:
> The smsc95xx_ioctl function behaves identically to the
> phy_do_ioctl_running function. Remove it and use the
> phy_do_ioctl_running function directly instead.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/net/usb/smsc95xx.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
Here is the summary with links:
- [net-next] net: usb: smsc95xx: use phy_do_ioctl_running function
https://git.kernel.org/netdev/net-next/c/2dd698f68e3c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-27 3:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-24 8:07 [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Ethan Nelson-Moore
2026-01-24 18:49 ` Andrew Lunn
2026-01-27 3:40 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-01-07 6:57 [PATCH net-next] net: usb: introduce usbnet_mii_ioctl helper function Ethan Nelson-Moore
2026-01-07 6:57 ` [PATCH net-next] net: usb: smsc95xx: use phy_do_ioctl_running function Ethan Nelson-Moore
2026-01-07 17:39 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox