* [PATCH net-next] selftests: drv-net: rss_flow_label: skip unsupported devices
@ 2026-01-28 9:02 Nimrod Oren
2026-01-30 2:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Nimrod Oren @ 2026-01-28 9:02 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Shuah Khan
Cc: netdev, linux-kselftest, linux-kernel, Nimrod Oren, Gal Pressman
The test_rss_flow_label_6only test case fails on devices that do not
support IPv6 flow label hashing. Make it skip neatly, consistent with
the behavior of the test_rss_flow_label case.
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Nimrod Oren <noren@nvidia.com>
---
| 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
--git a/tools/testing/selftests/drivers/net/hw/rss_flow_label.py b/tools/testing/selftests/drivers/net/hw/rss_flow_label.py
index 6fa95fe27c47..7dc80070884a 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_flow_label.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_flow_label.py
@@ -145,9 +145,14 @@ def test_rss_flow_label_6only(cfg):
# Try to enable Flow Labels and check again, in case it leaks thru
initial = _ethtool_get_cfg(cfg, "udp6")
- changed = initial.replace("l", "") if "l" in initial else initial + "l"
-
- cmd(f"ethtool -N {cfg.ifname} rx-flow-hash udp6 {changed}")
+ no_lbl = initial.replace("l", "")
+ if "l" not in initial:
+ try:
+ cmd(f"ethtool -N {cfg.ifname} rx-flow-hash udp6 l{no_lbl}")
+ except CmdExitFailure as exc:
+ raise KsftSkipEx("Device doesn't support Flow Label for UDP6") from exc
+ else:
+ cmd(f"ethtool -N {cfg.ifname} rx-flow-hash udp6 {no_lbl}")
restore = defer(cmd, f"ethtool -N {cfg.ifname} rx-flow-hash udp6 {initial}")
_check_v4_flow_types(cfg)
--
2.45.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] selftests: drv-net: rss_flow_label: skip unsupported devices
2026-01-28 9:02 [PATCH net-next] selftests: drv-net: rss_flow_label: skip unsupported devices Nimrod Oren
@ 2026-01-30 2:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-01-30 2:50 UTC (permalink / raw)
To: Nimrod Oren
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, shuah, netdev,
linux-kselftest, linux-kernel, gal
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 28 Jan 2026 11:02:17 +0200 you wrote:
> The test_rss_flow_label_6only test case fails on devices that do not
> support IPv6 flow label hashing. Make it skip neatly, consistent with
> the behavior of the test_rss_flow_label case.
>
> Reviewed-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Nimrod Oren <noren@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] selftests: drv-net: rss_flow_label: skip unsupported devices
https://git.kernel.org/netdev/net-next/c/7b85c7758540
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-30 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 9:02 [PATCH net-next] selftests: drv-net: rss_flow_label: skip unsupported devices Nimrod Oren
2026-01-30 2:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox