Re: [net-next,v24,6/6] eea: introduce callback for ndo_get_stats64

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

On Fri, 30 Jan 2026 15:32:45 -0800, Jakub Kicinski <kuba@kernel.org> wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
>
> For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
> ---
> eea: introduce callback for ndo_get_stats64
>
> This commit adds ndo_get_stats64 support to the Alibaba Elastic Ethernet
> Adapter driver and introduces a spinlock to protect concurrent access to
> rx and tx pointers when gathering statistics.
>
> The commit message says "Add basic driver framework for the Alibaba
> Elastic Ethernet Adapter(EEA)." But shouldn't this say it's adding stats
> support to an existing framework rather than adding the basic framework
> itself? The other commits in the series appear to have already introduced
> the framework.

Will update the commit log.


>
> This commit introduces a spinlock to protect against races between
> eea_stats() and the queue setup/teardown functions. The race being fixed
> was introduced in commit cf49df362e30 ("eea: create/destroy rx,tx queues
> for netdevice open and stop"). Should this commit include a Fixes: tag?

Not fix, before this commit, there is no race problem.
There are protected by rtnl.

Thanks.



>
> Fixes: cf49df362e30 ("eea: create/destroy rx,tx queues for netdevice open and stop")