From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
andrew@lunn.ch, maxime.chevallier@bootlin.com, gal@nvidia.com
Subject: Re: [PATCH net] net: rss: fix reporting RXH_XFRM_NO_CHANGE as input_xfrm for contexts
Date: Tue, 03 Feb 2026 01:20:05 +0000 [thread overview]
Message-ID: <177008160562.1261691.14643963263135767884.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260130190311.811129-1-kuba@kernel.org>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 30 Jan 2026 11:03:11 -0800 you wrote:
> Initializing input_xfrm to RXH_XFRM_NO_CHANGE in RSS contexts is
> problematic. I think I did this to make it clear that the context
> does not have its own settings applied. But unlike ETH_RSS_HASH_NO_CHANGE
> which is zero, RXH_XFRM_NO_CHANGE is 0xff. We need to be careful
> when reading the value back, and remember to treat 0xff as 0.
>
> Remove the initialization and switch to storing 0. This lets us
> also remove the workaround in ethnl_rss_set(). Get side does not
> need any adjustments and context get no longer reports:
>
> [...]
Here is the summary with links:
- [net] net: rss: fix reporting RXH_XFRM_NO_CHANGE as input_xfrm for contexts
https://git.kernel.org/netdev/net/c/1c172febdf06
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-02-03 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 19:03 [PATCH net] net: rss: fix reporting RXH_XFRM_NO_CHANGE as input_xfrm for contexts Jakub Kicinski
2026-02-03 1:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177008160562.1261691.14643963263135767884.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox