[PATCH v2 net-next] bng_en: fix misleading error message for generic firmware version

[PATCH v2 net-next] bng_en: fix misleading error message for generic firmware version

[Alok Tiwari]

The devlink info_get handler incorrectly reports "roce firmware" when
populating the generic firmware version field.

Update the error message to correctly describe the failing operation.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
v1 -> v2
remove generic word in ERR_MSG
---
 drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
index a987afebd64d..f3a984d4d5f1 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
@@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
 			      DEVLINK_INFO_VERSION_GENERIC_FW, buf);
 	if (rc) {
 		NL_SET_ERR_MSG_MOD(extack,
-				   "Failed to set roce firmware version");
+				   "Failed to set firmware version");
 		return rc;
 	}
 
-- 
2.50.1

Re: [PATCH v2 net-next] bng_en: fix misleading error message for generic firmware version

[Vikas Gupta]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

On Mon, Feb 2, 2026 at 9:09 AM Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
>
> The devlink info_get handler incorrectly reports "roce firmware" when
> populating the generic firmware version field.
>
> Update the error message to correctly describe the failing operation.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>

> ---
> v1 -> v2
> remove generic word in ERR_MSG
> ---
>  drivers/net/ethernet/broadcom/bnge/bnge_devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> index a987afebd64d..f3a984d4d5f1 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_devlink.c
> @@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
>                               DEVLINK_INFO_VERSION_GENERIC_FW, buf);
>         if (rc) {
>                 NL_SET_ERR_MSG_MOD(extack,
> -                                  "Failed to set roce firmware version");
> +                                  "Failed to set firmware version");
>                 return rc;
>         }
>
> --
> 2.50.1
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5465 bytes --]

Re: [PATCH v2 net-next] bng_en: fix misleading error message for generic firmware version

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun,  1 Feb 2026 19:38:43 -0800 you wrote:
> The devlink info_get handler incorrectly reports "roce firmware" when
> populating the generic firmware version field.
> 
> Update the error message to correctly describe the failing operation.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> 
> [...]

Here is the summary with links:
  - [v2,net-next] bng_en: fix misleading error message for generic firmware version
    https://git.kernel.org/netdev/net-next/c/1384a81e54fa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html