From: Jesper Dangaard Brouer <hawk@kernel.org>
To: netdev@vger.kernel.org, "Eric Dumazet" <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
bpf@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
horms@kernel.org, jiri@resnulli.us, edumazet@google.com,
xiyou.wangcong@gmail.com, jhs@mojatatu.com, atenart@redhat.com,
carges@cloudflare.com, kernel-team@cloudflare.com
Subject: [PATCH net-next v3 5/6] net: sched: rename QDISC_DROP_FQ_* to generic names
Date: Fri, 06 Feb 2026 17:24:49 +0100 [thread overview]
Message-ID: <177039508922.2258217.2724637003148631081.stgit@firesoul> (raw)
In-Reply-To: <177039500964.2258217.2989656069254156812.stgit@firesoul>
Rename FQ-specific drop reasons to generic names:
- QDISC_DROP_FQ_BAND_LIMIT -> QDISC_DROP_BAND_LIMIT
- QDISC_DROP_FQ_HORIZON_LIMIT -> QDISC_DROP_HORIZON_LIMIT
This follows the principle that drop reasons should describe the drop
mechanism rather than being tied to a specific qdisc implementation.
These concepts (priority band limits, timestamp horizon) could apply
to other qdiscs as well.
Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
---
include/net/dropreason-qdisc.h | 21 +++++++++++----------
net/sched/sch_fq.c | 2 +-
2 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/include/net/dropreason-qdisc.h b/include/net/dropreason-qdisc.h
index 2e2f4fc36e0d..8661797193b1 100644
--- a/include/net/dropreason-qdisc.h
+++ b/include/net/dropreason-qdisc.h
@@ -12,8 +12,8 @@
FN(FLOW_LIMIT) \
FN(MAXFLOWS) \
FN(FLOOD_PROTECTION) \
- FN(FQ_BAND_LIMIT) \
- FN(FQ_HORIZON_LIMIT) \
+ FN(BAND_LIMIT) \
+ FN(HORIZON_LIMIT) \
FNe(MAX)
#undef FN
@@ -82,17 +82,18 @@ enum qdisc_drop_reason {
*/
QDISC_DROP_FLOOD_PROTECTION,
/**
- * @QDISC_DROP_FQ_BAND_LIMIT: FQ (Fair Queue) dropped packet because
- * the priority band's packet limit was reached. Each priority band
- * in FQ has its own limit.
+ * @QDISC_DROP_BAND_LIMIT: packet dropped because the priority band's
+ * limit was reached. Used by qdiscs with priority bands that have
+ * per-band packet limits (e.g., FQ).
*/
- QDISC_DROP_FQ_BAND_LIMIT,
+ QDISC_DROP_BAND_LIMIT,
/**
- * @QDISC_DROP_FQ_HORIZON_LIMIT: FQ dropped packet because its
- * timestamp is too far in the future (beyond horizon). This prevents
- * packets with unreasonable future timestamps from blocking the queue.
+ * @QDISC_DROP_HORIZON_LIMIT: packet dropped because its timestamp
+ * is too far in the future (beyond horizon). This prevents packets
+ * with unreasonable future timestamps from occupying queue space.
+ * Used by qdiscs with time-based scheduling (e.g., FQ).
*/
- QDISC_DROP_FQ_HORIZON_LIMIT,
+ QDISC_DROP_HORIZON_LIMIT,
/**
* @QDISC_DROP_MAX: the maximum of qdisc drop reasons, which
* shouldn't be used as a real 'reason' - only for tracing code gen
diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c
index d36da3918b55..f8f360d28da0 100644
--- a/net/sched/sch_fq.c
+++ b/net/sched/sch_fq.c
@@ -541,7 +541,7 @@ static bool fq_packet_beyond_horizon(const struct sk_buff *skb,
return unlikely((s64)skb->tstamp > (s64)(now + q->horizon));
}
-#define FQDR(reason) QDISC_DROP_FQ_##reason
+#define FQDR(reason) QDISC_DROP_##reason
static int fq_enqueue(struct sk_buff *skb, struct Qdisc *sch,
struct sk_buff **to_free)
next prev parent reply other threads:[~2026-02-06 16:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 16:24 [PATCH net-next v3 0/6] net: sched: refactor qdisc drop reasons into dedicated tracepoint Jesper Dangaard Brouer
2026-02-06 16:24 ` [PATCH net-next v3 1/6] net: sched: introduce qdisc-specific drop reason tracing Jesper Dangaard Brouer
2026-02-10 11:47 ` Toke Høiland-Jørgensen
2026-02-11 8:36 ` Paolo Abeni
2026-02-11 8:46 ` Paolo Abeni
2026-02-13 17:50 ` Jesper Dangaard Brouer
2026-02-11 8:50 ` Paolo Abeni
2026-02-06 16:24 ` [PATCH net-next v3 2/6] net: sched: sfq: convert to qdisc drop reasons Jesper Dangaard Brouer
2026-02-10 11:48 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 3/6] net: sched: sch_cake: use enum qdisc_drop_reason for cobalt_should_drop Jesper Dangaard Brouer
2026-02-10 11:52 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 4/6] net: sched: rename QDISC_DROP_CAKE_FLOOD to QDISC_DROP_FLOOD_PROTECTION Jesper Dangaard Brouer
2026-02-10 11:53 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` Jesper Dangaard Brouer [this message]
2026-02-10 11:54 ` [PATCH net-next v3 5/6] net: sched: rename QDISC_DROP_FQ_* to generic names Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 6/6] net: sched: sch_dualpi2: use qdisc_dequeue_drop() for dequeue drops Jesper Dangaard Brouer
2026-02-10 12:00 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177039508922.2258217.2724637003148631081.stgit@firesoul \
--to=hawk@kernel.org \
--cc=atenart@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=carges@cloudflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox