[PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports

[PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports

[Alok Tiwari]

In prestera_ethtool_set_fecparam(), the error message is opposite of
the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is
not allowed on SFP ports, but the message says "non-SFP ports", which
does not match the condition. However, FEC may be required depending on
the transceiver, cable, or mode, and firmware already validates invalid
combinations.

Remove the SFP transceiver check and let firmware handle validation.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
v1 -> v2
remove condition of if (port->caps.transceiver ==
PRESTERA_PORT_TCVR_SFP)  check instead of error message correction
---
 drivers/net/ethernet/marvell/prestera/prestera_ethtool.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
index 2f52daba58e6..750c72f628e5 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
@@ -717,11 +717,6 @@ static int prestera_ethtool_set_fecparam(struct net_device *dev,
 		return -EINVAL;
 	}
 
-	if (port->caps.transceiver == PRESTERA_PORT_TCVR_SFP) {
-		netdev_err(dev, "FEC set is not allowed on non-SFP ports\n");
-		return -EINVAL;
-	}
-
 	fec = PRESTERA_PORT_FEC_MAX;
 	for (mode = 0; mode < PRESTERA_PORT_FEC_MAX; mode++) {
 		if ((port_fec_caps[mode].eth_fec & fecparam->fec) &&
-- 
2.50.1

RE: [EXTERNAL] [PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports

[Elad Nachman]

> 
> 
> From: Alok Tiwari <alok.a.tiwari@oracle.com>
> Sent: Thursday, February 5, 2026 11:20 AM
> To: Elad Nachman <enachman@marvell.com>; Taras Chornyi [C] <tchornyi@marvell.com>; Volodymyr Mytnyk [C] <vmytnyk@marvell.com>; Vadym Kochan [C] <vkochan@marvell.com>; pabeni@redhat.com; kuba@kernel.org; edumazet@google.com; davem@davemloft.net; andrew+netdev@lunn.ch; netdev@vger.kernel.org
> Cc: alok.a.tiwarilinux@gmail.com; alok.a.tiwari@oracle.com
> Subject: [EXTERNAL] [PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports
> 
> In prestera_ethtool_set_fecparam(), the error message is opposite of
> the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is
> not allowed on SFP ports, but the message says "non-SFP ports", which
> does not match the condition. However, FEC may be required depending on
> the transceiver, cable, or mode, and firmware already validates invalid
> combinations.
> 
> Remove the SFP transceiver check and let firmware handle validation.
> 
> Signed-off-by: Alok Tiwari <mailto:alok.a.tiwari@oracle.com>
> ---
> v1 -> v2
> remove condition of if (port->caps.transceiver ==
> PRESTERA_PORT_TCVR_SFP)  check instead of error message correction
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_ethtool.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> index 2f52daba58e6..750c72f628e5 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
> @@ -717,11 +717,6 @@ static int prestera_ethtool_set_fecparam(struct net_device *dev,
>  		return -EINVAL;
>  	}
> 
> -	if (port->caps.transceiver == PRESTERA_PORT_TCVR_SFP) {
> -		netdev_err(dev, "FEC set is not allowed on non-SFP ports\n");
> -		return -EINVAL;
> -	}
> -
>  	fec = PRESTERA_PORT_FEC_MAX;
>  	for (mode = 0; mode < PRESTERA_PORT_FEC_MAX; mode++) {
>  		if ((port_fec_caps[mode].eth_fec & fecparam->fec) &&
> --
> 2.50.1
>

Acked-by: Elad Nachman <enachman@marvell.com>

Re: [PATCH v2 net-next] net: marvell: prestera: fix FEC error message for SFP ports

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  5 Feb 2026 01:19:55 -0800 you wrote:
> In prestera_ethtool_set_fecparam(), the error message is opposite of
> the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is
> not allowed on SFP ports, but the message says "non-SFP ports", which
> does not match the condition. However, FEC may be required depending on
> the transceiver, cable, or mode, and firmware already validates invalid
> combinations.
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net: marvell: prestera: fix FEC error message for SFP ports
    https://git.kernel.org/netdev/net-next/c/dddb0198c2a8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html