2.6.19-rc1 regression: airo suspend fails

2.6.19-rc1 regression: airo suspend fails

[Adrian Bunk]

On Thu, Oct 05, 2006 at 09:31:16PM -0700, Alex Romosan wrote:
> Linus Torvalds <torvalds@osdl.org> writes:
> 
> > so please give it a good testing, and let's see if there are any 
> > regressions.
> 
> it breaks suspend when the airo module is loaded:
> 
> kernel: Stopping tasks: =================================================================================
> kernel:  stopping tasks timed out after 20 seconds (1 tasks remaining):
> kernel:   eth1
> kernel: Restarting tasks...<6> Strange, eth1 not stopped
> 
> if i remove the airo module suspend works normally (this is on a
> thinkpad t40).

Thanks for your report.

Let's try to figure out what broke it.

As a first step, please replace drivers/net/wireless/airo.c with the 
version in 2.6.18 and check whether this fixes the issue (you can ignore 
the deprecated warning during compilation).

> --alex--

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.19-rc1 regression: airo suspend fails

[Alex Romosan]

Adrian Bunk <bunk@stusta.de> writes:

> On Thu, Oct 05, 2006 at 09:31:16PM -0700, Alex Romosan wrote:
>> Linus Torvalds <torvalds@osdl.org> writes:
>> 
>> > so please give it a good testing, and let's see if there are any 
>> > regressions.
>> 
>> it breaks suspend when the airo module is loaded:
>> 
>> kernel: Stopping tasks: =================================================================================
>> kernel:  stopping tasks timed out after 20 seconds (1 tasks remaining):
>> kernel:   eth1
>> kernel: Restarting tasks...<6> Strange, eth1 not stopped
>> 
>> if i remove the airo module suspend works normally (this is on a
>> thinkpad t40).
>
> Thanks for your report.
>
> Let's try to figure out what broke it.
>
> As a first step, please replace drivers/net/wireless/airo.c with the 
> version in 2.6.18 and check whether this fixes the issue (you can ignore 
> the deprecated warning during compilation).

i replaced airo.c with the 2.6.18 version. the good news is i can
suspend to memory with it. the bad news is dhcp never got an ip
address (so i don't think the 2.6.18 driver really works with the
2.6.19-rc1 infrastructure). any patches i could try? thanks.

--alex--

-- 
| I believe the moment is at hand when, by a paranoiac and active |
|  advance of the mind, it will be possible (simultaneously with  |
|  automatism and other passive states) to systematize confusion  |
|  and thus to help to discredit completely the world of reality. |

Re: 2.6.19-rc1 regression: airo suspend fails

[Dave Kleikamp]

On Fri, 2006-10-06 at 20:47 +0200, Adrian Bunk wrote:
> On Thu, Oct 05, 2006 at 09:31:16PM -0700, Alex Romosan wrote:

> > it breaks suspend when the airo module is loaded:
> > 
> > kernel: Stopping tasks: =================================================================================
> > kernel:  stopping tasks timed out after 20 seconds (1 tasks remaining):
> > kernel:   eth1
> > kernel: Restarting tasks...<6> Strange, eth1 not stopped
> > 
> > if i remove the airo module suspend works normally (this is on a
> > thinkpad t40).
> 
> Thanks for your report.
> 
> Let's try to figure out what broke it.

I believe it was broken by:
http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3b4c7d640376dbccfe80fc4f7b8772ecc7de28c5

I have seen this in the -mm tree, but didn't follow up at the time.  I
was able to fix it with the following patch.  I don't know if it's the
best fix, but it seems to follow the same logic as the original code.


The airo driver used to break out of while loop if there were any signals
pending.  Since it no longer checks for signals, it at least needs to check
if it needs to be frozen.

Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>

diff -Nurp linux-2.6.19-rc1/drivers/net/wireless/airo.c linux/drivers/net/wireless/airo.c
--- linux-2.6.19-rc1/drivers/net/wireless/airo.c	2006-10-05 07:22:39.000000000 -0500
+++ linux/drivers/net/wireless/airo.c	2006-10-07 13:42:13.000000000 -0500
@@ -3090,7 +3090,8 @@ static int airo_thread(void *data) {
 						set_bit(JOB_AUTOWEP, &ai->jobs);
 						break;
 					}
-					if (!kthread_should_stop()) {
+					if (!kthread_should_stop() &&
+					    !freezing(current)) {
 						unsigned long wake_at;
 						if (!ai->expires || !ai->scan_timeout) {
 							wake_at = max(ai->expires,
@@ -3102,7 +3103,8 @@ static int airo_thread(void *data) {
 						schedule_timeout(wake_at - jiffies);
 						continue;
 					}
-				} else if (!kthread_should_stop()) {
+				} else if (!kthread_should_stop() &&
+					   !freezing(current)) {
 					schedule();
 					continue;
 				}

-- 
David Kleikamp
IBM Linux Technology Center

Re: 2.6.19-rc1 regression: airo suspend fails

[Alex Romosan]

Dave Kleikamp <shaggy@austin.ibm.com> writes:

> I believe it was broken by:
> http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3b4c7d640376dbccfe80fc4f7b8772ecc7de28c5
>
> I have seen this in the -mm tree, but didn't follow up at the time.  I
> was able to fix it with the following patch.  I don't know if it's the
> best fix, but it seems to follow the same logic as the original code.
>
>
> The airo driver used to break out of while loop if there were any signals
> pending.  Since it no longer checks for signals, it at least needs to check
> if it needs to be frozen.
>
> Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
>
> diff -Nurp linux-2.6.19-rc1/drivers/net/wireless/airo.c linux/drivers/net/wireless/airo.c
> --- linux-2.6.19-rc1/drivers/net/wireless/airo.c	2006-10-05 07:22:39.000000000 -0500
> +++ linux/drivers/net/wireless/airo.c	2006-10-07 13:42:13.000000000 -0500
> @@ -3090,7 +3090,8 @@ static int airo_thread(void *data) {
>  						set_bit(JOB_AUTOWEP, &ai->jobs);
>  						break;
>  					}
> -					if (!kthread_should_stop()) {
> +					if (!kthread_should_stop() &&
> +					    !freezing(current)) {
>  						unsigned long wake_at;
>  						if (!ai->expires || !ai->scan_timeout) {
>  							wake_at = max(ai->expires,
> @@ -3102,7 +3103,8 @@ static int airo_thread(void *data) {
>  						schedule_timeout(wake_at - jiffies);
>  						continue;
>  					}
> -				} else if (!kthread_should_stop()) {
> +				} else if (!kthread_should_stop() &&
> +					   !freezing(current)) {
>  					schedule();
>  					continue;
>  				}
>

thanks. with this patch applied i can suspend to ram with the airo
module loaded.

--alex--

-- 
| I believe the moment is at hand when, by a paranoiac and active |
|  advance of the mind, it will be possible (simultaneously with  |
|  automatism and other passive states) to systematize confusion  |
|  and thus to help to discredit completely the world of reality. |

2.6.19-rc1: known regressions (v2)

[Adrian Bunk]

This email lists some known regressions in 2.6.19-rc1 compared to 2.6.18
that are not yet fixed Linus' tree.

If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you was declared guilty for a breakage or I'm considering you in any
other way possibly involved with one or more of these issues.

Due to the huge amount of recipients, please trim the Cc when answering.


Subject    : SMP x86_64 boot problem
References : http://lkml.org/lkml/2006/9/28/330
             http://lkml.org/lkml/2006/10/5/289
Submitter  : art@usfltd.com
Status     : submitter was asked to git bisect
             result of bisecting seems to be wrong


Subject    : snd-hda-intel <-> forcedeth MSI problem
References : http://lkml.org/lkml/2006/10/5/40
Submitter  : Prakash Punnoor <prakash@punnoor.de>
Status     : unknown


Subject    : oops in xfrm_register_mode
References : http://lkml.org/lkml/2006/10/4/170
Submitter  : Steve Fox <drfickle@us.ibm.com>
Status     : unknown


Subject    : T60 stops triggering any ACPI events
References : http://lkml.org/lkml/2006/10/4/425
Submitter  : "Michael S. Tsirkin" <mst@mellanox.co.il>
Status     : unknown


Subject    : thinkpad x60: brightness no longer adjustable in 2.6.18-git
References : http://lkml.org/lkml/2006/10/2/300
Submitter  : Pavel Machek <pavel@ucw.cz>
Status     : unknown, related to the issue above?


Subject    : monitor not active after boot
References : http://lkml.org/lkml/2006/10/5/338
Submitter  : Olaf Hering <olaf@aepfle.de>
Guilty     : Antonino Daplas <adaplas@pol.net>
             commit 346bc21026e7a92e1d7a4a1b3792c5e8b686133d
Status     : unknown


Subject    : sata-via doesn't detect anymore disks attached to VIA vt6421
References : http://bugzilla.kernel.org/show_bug.cgi?id=7255
Submitter  : Thierry Vignaud <tvignaud@mandriva.com>
Status     : unknown


Subject    : ueagle-atm Oops
References : http://lkml.org/lkml/2006/10/6/390
Submitter  : Ernst Herzberg <list-lkml@net4u.de>
Handled-By : Matthieu Castet <castet.matthieu@free.fr>
Status     : unknown


Subject    : DVD drive lost DVD capabilities
References : http://lkml.org/lkml/2006/10/1/45
Submitter  : Olaf Hering <olaf@aepfle.de>
Guilty     : Jens Axboe <axboe@oracle.com>
             commit 4aff5e2333c9a1609662f2091f55c3f6fffdad36
Handled-By : Jens Axboe <axboe@oracle.com>
Status     : Jens is working on a fix


Subject    : sleep/wakeup on powerbooks apparently busted
References : http://lkml.org/lkml/2006/10/5/13
Submitter  : Benjamin Herrenschmidt <benh@kernel.crashing.org>
Handled-By : Benjamin Herrenschmidt <benh@kernel.crashing.org>
Status     : Benjamin will investigate


Subject    : doesn't boot on iBook G4
References : http://lkml.org/lkml/2006/10/5/305
Submitter  : Andreas Schwab <schwab@suse.de>
Handled-By : Mel Gorman <mel@skynet.ie>
Patch      : http://lkml.org/lkml/2006/10/6/80
Status     : patch available


Subject    : airo suspend fails
References : http://lkml.org/lkml/2006/10/6/3
Submitter  : Alex Romosan <romosan@sycorax.lbl.gov>
Guilty     : Sukadev Bhattiprolu <sukadev@us.ibm.com>  (?)
             commit 3b4c7d640376dbccfe80fc4f7b8772ecc7de28c5  (?)
Handled-By : Dave Kleikamp <shaggy@austin.ibm.com>
Patch      : http://lkml.org/lkml/2006/10/7/139
Status     : patch available


Subject    : NFSv4 fails to mount (timeout)
References : http://bugzilla.kernel.org/show_bug.cgi?id=7274
Submitter  : Torsten Kaiser <kernel@bardioc.dyndns.org>
Guilty     : Trond Myklebust <Trond.Myklebust@netapp.com>
             commit 51b6ded4d9a94a61035deba1d8f51a54e3a3dd86
Handled-By : Trond Myklebust <Trond.Myklebust@netapp.com>
Patch      : http://bugzilla.kernel.org/show_bug.cgi?id=7274
Status     : patch available


Subject    : kexec broken on x86_64
References : http://lkml.org/lkml/2006/10/5/86
Submitter  : Magnus Damm <magnus.damm@gmail.com>
Handled-By : Vivek Goyal <vgoyal@in.ibm.com>
Patch      : http://lkml.org/lkml/2006/10/5/199
Status     : patch available


Subject    : strange ieee1394 messages
References : http://lkml.org/lkml/2006/10/5/154
Submitter  : "Alistair John Strachan" <s0348365@sms.ed.ac.uk>
Guilty     : Stefan Richter <stefanr@s5r6.in-berlin.de>
             commit d2f119fe319528da8c76a1107459d6f478cbf28c
Handled-By : Stefan Richter <stefanr@s5r6.in-berlin.de>
Patch      : http://lkml.org/lkml/2006/10/6/235
Status     : harmless, patch available

Re: 2.6.19-rc1 regression: airo suspend fails

[Pavel Machek]

Hi!

> > > it breaks suspend when the airo module is loaded:
> > > 
> > > kernel: Stopping tasks: =================================================================================
> > > kernel:  stopping tasks timed out after 20 seconds (1 tasks remaining):
> > > kernel:   eth1
> > > kernel: Restarting tasks...<6> Strange, eth1 not stopped
> > > 
> > > if i remove the airo module suspend works normally (this is on a
> > > thinkpad t40).
> > 
> > Thanks for your report.
> > 
> > Let's try to figure out what broke it.
> 
> I believe it was broken by:
> http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3b4c7d640376dbccfe80fc4f7b8772ecc7de28c5
> 
> I have seen this in the -mm tree, but didn't follow up at the time.  I
> was able to fix it with the following patch.  I don't know if it's the
> best fix, but it seems to follow the same logic as the original code.
> 
> 
> The airo driver used to break out of while loop if there were any signals
> pending.  Since it no longer checks for signals, it at least needs to check
> if it needs to be frozen.
> 
> Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>

ACK. Please push it to akpm or airo maintainers...

								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: 2.6.19-rc1: known regressions (v2)

[matthieu castet]

Hi,

Adrian Bunk wrote:
> This email lists some known regressions in 2.6.19-rc1 compared to 2.6.18
> that are not yet fixed Linus' tree.
> 
> If you find your name in the Cc header, you are either submitter of one
> of the bugs, maintainer of an affectected subsystem or driver, a patch
> of you was declared guilty for a breakage or I'm considering you in any
> other way possibly involved with one or more of these issues.
> 
> Due to the huge amount of recipients, please trim the Cc when answering.
> 
> 

> 
> Subject    : ueagle-atm Oops
> References : http://lkml.org/lkml/2006/10/6/390
> Submitter  : Ernst Herzberg <list-lkml@net4u.de>
> Handled-By : Matthieu Castet <castet.matthieu@free.fr>
> Status     : unknown
> 
> 
Guilty     :
http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e7ccdfec087f02930c5cdc81143d4a045ae8d361

Patch available at 
https://mail.gna.org/public/ueagleatm-dev/2006-10/msg00022.html , but 
some cleaning is need (I wasn't aware of "USB: fix __must_check warnings 
in drivers/usb/atm/" patch).

Matthieu

Re: 2.6.19-rc1: known regressions (v2) - xfrm_register_mode

[Steve Fox]

On Sat, 2006-10-07 at 23:46 +0200, Adrian Bunk wrote:
> Subject    : oops in xfrm_register_mode
> References : http://lkml.org/lkml/2006/10/4/170
> Submitter  : Steve Fox <drfickle@us.ibm.com>
> Status     : unknown

Status: Vivek and Mel have both created patches which fix the boot
issue, but it is not clear to me if either of these are acceptable
fixes.

-- 

Steve Fox
IBM Linux Technology Center

Re: 2.6.19-rc1: known regressions (v2) - xfrm_register_mode

[Mel Gorman]

On Mon, 9 Oct 2006, Steve Fox wrote:

> On Sat, 2006-10-07 at 23:46 +0200, Adrian Bunk wrote:
>> Subject    : oops in xfrm_register_mode
>> References : http://lkml.org/lkml/2006/10/4/170
>> Submitter  : Steve Fox <drfickle@us.ibm.com>
>> Status     : unknown
>
> Status: Vivek and Mel have both created patches which fix the boot
> issue, but it is not clear to me if either of these are acceptable
> fixes.
>

I suggest taking Vivek's.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

2.6.19-rc1: known regressions (v3)

[Adrian Bunk]

This email lists some known regressions in 2.6.19-rc1 compared to 2.6.18
that are not yet fixed Linus' tree.

If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering you in any other way possibly
involved with one or more of these issues.

Due to the huge amount of recipients, please trim the Cc when answering.


Subject    : sata-via doesn't detect anymore disks attached to VIA vt6421
References : http://bugzilla.kernel.org/show_bug.cgi?id=7255
Submitter  : Thierry Vignaud <tvignaud@mandriva.com>
Status     : unknown


Subject    : monitor not active after boot
References : http://lkml.org/lkml/2006/10/5/338
Submitter  : Olaf Hering <olaf@aepfle.de>
Caused-By  : Antonino Daplas <adaplas@pol.net>
             commit 346bc21026e7a92e1d7a4a1b3792c5e8b686133d
Status     : unknown


Subject    : SMP x86_64 boot problem
References : http://lkml.org/lkml/2006/9/28/330
             http://lkml.org/lkml/2006/10/5/289
Submitter  : art@usfltd.com
Status     : submitter was asked to git bisect
             result of bisecting seems to be wrong


Subject    : sleep/wakeup on powerbooks apparently busted
References : http://lkml.org/lkml/2006/10/5/13
Submitter  : Benjamin Herrenschmidt <benh@kernel.crashing.org>
Handled-By : Benjamin Herrenschmidt <benh@kernel.crashing.org>
Status     : Benjamin will investigate


Subject    : w83781d modprobing failure
References : http://bugzilla.kernel.org/show_bug.cgi?id=7293
Submitter  : Sylvain BERTRAND <sylvain.bertrand@gmail.com>
Caused-By  : David Hubbard <david.c.hubbard@gmail.com> (?)
             commit 8202632647278eba7223727dc442f49227c040d0 (?)
Handled-By : Jean Delvare <khali@linux-fr.org>
Status     : Jean is investigating


Subject    : CD/DVD drives lost capabilities
References : http://lkml.org/lkml/2006/10/1/45
             http://bugzilla.kernel.org/show_bug.cgi?id=7284
Submitter  : Olaf Hering <olaf@aepfle.de>
             Johannes Berg <johannes@sipsolutions.net>
Caused-By  : Jens Axboe <jens.axboe@oracle.com>
             commit 4aff5e2333c9a1609662f2091f55c3f6fffdad36
Handled-By : Jens Axboe <jens.axboe@oracle.com>
Status     : Jens is working on a fix


Subject    : snd-hda-intel <-> forcedeth MSI problem
References : http://lkml.org/lkml/2006/10/5/40
             http://lkml.org/lkml/2006/10/7/164
Submitter  : Prakash Punnoor <prakash@punnoor.de>
Status     : suggested workaround for 2.6.19:
             deactivate MSI in snd-intel-hda by default


Subject    : DVB frontend selection causes compile errors
References : http://lkml.org/lkml/2006/10/8/244
Submitter  : Adrian Bunk <bunk@stusta.de>
Caused-By  : "Andrew de Quincey" <adq_dvb@lidskialf.net>
             commit 176ac9da4f09820a43fd48f0e74b1486fc3603ba
Handled-By : Michael Krufky <mkrufky@linuxtv.org>
             "Andrew de Quincey" <adq_dvb@lidskialf.net>
Status     : possible workaround: don't allow CONFIG_DVB_FE_CUSTOMISE=y


Subject    : ueagle-atm Oops
References : http://lkml.org/lkml/2006/10/6/390
Submitter  : Ernst Herzberg <list-lkml@net4u.de>
Caused-By  : Greg Kroah-Hartman <gregkh@suse.de>
             commit e7ccdfec087f02930c5cdc81143d4a045ae8d361
Handled-By : Matthieu Castet <castet.matthieu@free.fr>
             Laurent Riffard
Patch      : https://mail.gna.org/public/ueagleatm-dev/2006-10/msg00022.html
Status     : "patch available, but some cleaning is needed"


Subject    : oops in xfrm_register_mode
References : http://lkml.org/lkml/2006/10/4/170
Submitter  : Steve Fox <drfickle@us.ibm.com>
Handled-By : Vivek Goyal <vgoyal@in.ibm.com>
Status     : patch available


Subject    : doesn't boot on iBook G4
References : http://lkml.org/lkml/2006/10/5/305
Submitter  : Andreas Schwab <schwab@suse.de>
Handled-By : Mel Gorman <mel@skynet.ie>
Patch      : http://lkml.org/lkml/2006/10/6/80
Status     : patch available


Subject    : airo suspend fails
References : http://lkml.org/lkml/2006/10/6/3
Submitter  : Alex Romosan <romosan@sycorax.lbl.gov>
Caused-By  : Sukadev Bhattiprolu <sukadev@us.ibm.com>  (?)
             commit 3b4c7d640376dbccfe80fc4f7b8772ecc7de28c5  (?)
Handled-By : Dave Kleikamp <shaggy@austin.ibm.com>
Patch      : http://lkml.org/lkml/2006/10/7/139
Status     : patch available


Subject    : kexec broken on x86_64
References : http://lkml.org/lkml/2006/10/5/86
Submitter  : Magnus Damm <magnus.damm@gmail.com>
Handled-By : Vivek Goyal <vgoyal@in.ibm.com>
Patch      : http://lkml.org/lkml/2006/10/5/199
Status     : patch available


Subject    : NFSv4 fails to mount (timeout)
References : http://bugzilla.kernel.org/show_bug.cgi?id=7274
Submitter  : Torsten Kaiser <kernel@bardioc.dyndns.org>
Caused-By  : Trond Myklebust <Trond.Myklebust@netapp.com>
             commit 51b6ded4d9a94a61035deba1d8f51a54e3a3dd86
Handled-By : Trond Myklebust <Trond.Myklebust@netapp.com>
Patch      : http://bugzilla.kernel.org/show_bug.cgi?id=7274
Status     : patch available

Re: 2.6.19-rc1: known regressions (v3)

[Paul Mackerras]

Adrian Bunk writes:

> Subject    : sleep/wakeup on powerbooks apparently busted
> References : http://lkml.org/lkml/2006/10/5/13
> Submitter  : Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Handled-By : Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Status     : Benjamin will investigate

Should be fixed once Linus pulls the powerpc.git tree.

Paul.