public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] selftests: netconsole: Increase port listening timeout
@ 2026-02-10  0:59 Pin-yen Lin
  2026-02-12 15:01 ` Simon Horman
  2026-02-13 20:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Pin-yen Lin @ 2026-02-10  0:59 UTC (permalink / raw)
  To: Breno Leitao, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Shuah Khan
  Cc: linux-kselftest, netdev, linux-kernel, Pin-yen Lin

wait_for_port() can wait up to 2 seconds with the sleep and the polling
in wait_local_port_listen() combined. So, in netcons_basic.sh, the socat
process could die before the test writes to the netconsole.

Increase the timeout to 3 seconds to make netcons_basic.sh pass
consistently.

Fixes: 3dc6c76391cb ("selftests: net: Add IPv6 support to netconsole basic tests")
Signed-off-by: Pin-yen Lin <treapking@google.com>
---

 tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
index ae8abff4be40..64d3941576d5 100644
--- a/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
+++ b/tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
@@ -247,8 +247,8 @@ function listen_port_and_save_to() {
 		SOCAT_MODE="UDP6-LISTEN"
 	fi
 
-	# Just wait for 2 seconds
-	timeout 2 ip netns exec "${NAMESPACE}" \
+	# Just wait for 3 seconds
+	timeout 3 ip netns exec "${NAMESPACE}" \
 		socat "${SOCAT_MODE}":"${PORT}",fork "${OUTPUT}" 2> /dev/null
 }
 
-- 
2.53.0.273.g2a3d683680-goog

base-commit: 6d2f142b1e4b203387a92519d9d2e34752a79dbb
branch: net-upstream

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: netconsole: Increase port listening timeout
  2026-02-10  0:59 [PATCH net] selftests: netconsole: Increase port listening timeout Pin-yen Lin
@ 2026-02-12 15:01 ` Simon Horman
  2026-02-13 20:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-02-12 15:01 UTC (permalink / raw)
  To: Pin-yen Lin
  Cc: Breno Leitao, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Shuah Khan, linux-kselftest, netdev,
	linux-kernel

On Mon, Feb 09, 2026 at 04:59:36PM -0800, Pin-yen Lin wrote:
> wait_for_port() can wait up to 2 seconds with the sleep and the polling
> in wait_local_port_listen() combined. So, in netcons_basic.sh, the socat
> process could die before the test writes to the netconsole.
> 
> Increase the timeout to 3 seconds to make netcons_basic.sh pass
> consistently.
> 
> Fixes: 3dc6c76391cb ("selftests: net: Add IPv6 support to netconsole basic tests")
> Signed-off-by: Pin-yen Lin <treapking@google.com>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] selftests: netconsole: Increase port listening timeout
  2026-02-10  0:59 [PATCH net] selftests: netconsole: Increase port listening timeout Pin-yen Lin
  2026-02-12 15:01 ` Simon Horman
@ 2026-02-13 20:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-13 20:30 UTC (permalink / raw)
  To: Pin-yen Lin
  Cc: leitao, andrew+netdev, davem, edumazet, kuba, pabeni, shuah,
	linux-kselftest, netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  9 Feb 2026 16:59:36 -0800 you wrote:
> wait_for_port() can wait up to 2 seconds with the sleep and the polling
> in wait_local_port_listen() combined. So, in netcons_basic.sh, the socat
> process could die before the test writes to the netconsole.
> 
> Increase the timeout to 3 seconds to make netcons_basic.sh pass
> consistently.
> 
> [...]

Here is the summary with links:
  - [net] selftests: netconsole: Increase port listening timeout
    https://git.kernel.org/netdev/net/c/a68a9bd086c2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-13 20:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-10  0:59 [PATCH net] selftests: netconsole: Increase port listening timeout Pin-yen Lin
2026-02-12 15:01 ` Simon Horman
2026-02-13 20:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox