* [PATCH] printk: add CONFIG_PRINTK dependency for netconsole
@ 2026-02-13 7:44 Arnd Bergmann
2026-02-16 9:47 ` Simon Horman
2026-02-17 12:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-02-13 7:44 UTC (permalink / raw)
To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Petr Mladek, John Ogness, Breno Leitao
Cc: Arnd Bergmann, Antonio Quartulli, Sabrina Dubroca, Eric Biggers,
netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The 'select PRINTK_EXECUTION_CTX' line now causes a harmless warning
when NETCONSOLE_DYNAMIC is enabled but PRINTK is not:
WARNING: unmet direct dependencies detected for PRINTK_EXECUTION_CTX
Depends on [n]: PRINTK [=n]
Selected by [y]:
- NETCONSOLE_DYNAMIC [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETCONSOLE [=y] && SYSFS [=y] && CONFIGFS_FS [=y] && (NETCONSOLE [=y]!=y [=y] || CONFIGFS_FS [=y]!=m [=m])
In that configuration, the netconsole driver is useless anyway, so
avoid this with an added dependency that prevents CONFIG_NETCONSOLE
to be enabled without CONFIG_PRINTK.
Fixes: 60325c27d3cf ("printk: Add execution context (task name/CPU) to printk_info")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 4154a6f98c74..93d78b201d63 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -333,6 +333,7 @@ config MACSEC
config NETCONSOLE
tristate "Network console logging support"
+ depends on PRINTK
help
If you want to log kernel messages over the network, enable this.
See <file:Documentation/networking/netconsole.rst> for details.
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] printk: add CONFIG_PRINTK dependency for netconsole
2026-02-13 7:44 [PATCH] printk: add CONFIG_PRINTK dependency for netconsole Arnd Bergmann
@ 2026-02-16 9:47 ` Simon Horman
2026-02-17 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-02-16 9:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Petr Mladek, John Ogness, Breno Leitao,
Arnd Bergmann, Antonio Quartulli, Sabrina Dubroca, Eric Biggers,
netdev, linux-kernel
On Fri, Feb 13, 2026 at 08:44:00AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The 'select PRINTK_EXECUTION_CTX' line now causes a harmless warning
> when NETCONSOLE_DYNAMIC is enabled but PRINTK is not:
>
> WARNING: unmet direct dependencies detected for PRINTK_EXECUTION_CTX
> Depends on [n]: PRINTK [=n]
> Selected by [y]:
> - NETCONSOLE_DYNAMIC [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETCONSOLE [=y] && SYSFS [=y] && CONFIGFS_FS [=y] && (NETCONSOLE [=y]!=y [=y] || CONFIGFS_FS [=y]!=m [=m])
>
> In that configuration, the netconsole driver is useless anyway, so
> avoid this with an added dependency that prevents CONFIG_NETCONSOLE
> to be enabled without CONFIG_PRINTK.
>
> Fixes: 60325c27d3cf ("printk: Add execution context (task name/CPU) to printk_info")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] printk: add CONFIG_PRINTK dependency for netconsole
2026-02-13 7:44 [PATCH] printk: add CONFIG_PRINTK dependency for netconsole Arnd Bergmann
2026-02-16 9:47 ` Simon Horman
@ 2026-02-17 12:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-17 12:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, pmladek,
john.ogness, leitao, arnd, antonio, sd, ebiggers, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 13 Feb 2026 08:44:00 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The 'select PRINTK_EXECUTION_CTX' line now causes a harmless warning
> when NETCONSOLE_DYNAMIC is enabled but PRINTK is not:
>
> WARNING: unmet direct dependencies detected for PRINTK_EXECUTION_CTX
> Depends on [n]: PRINTK [=n]
> Selected by [y]:
> - NETCONSOLE_DYNAMIC [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETCONSOLE [=y] && SYSFS [=y] && CONFIGFS_FS [=y] && (NETCONSOLE [=y]!=y [=y] || CONFIGFS_FS [=y]!=m [=m])
>
> [...]
Here is the summary with links:
- printk: add CONFIG_PRINTK dependency for netconsole
https://git.kernel.org/netdev/net/c/636fd32d4015
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-17 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-13 7:44 [PATCH] printk: add CONFIG_PRINTK dependency for netconsole Arnd Bergmann
2026-02-16 9:47 ` Simon Horman
2026-02-17 12:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox