* [PATCH net] eth: fbnic: Advertise supported XDP features.
@ 2026-02-18 3:06 Dimitri Daskalakis
2026-02-18 10:05 ` Simon Horman
2026-02-19 17:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dimitri Daskalakis @ 2026-02-18 3:06 UTC (permalink / raw)
To: David S . Miller
Cc: Alexander Duyck, Jakub Kicinski, Eric Dumazet, Paolo Abeni,
Andrew Lunn, Simon Horman, Alexei Starovoitov, Daniel Borkmann,
Jesper Dangaard Brouer, John Fastabend, Stanislav Fomichev,
Mohsin Bashir, netdev, bpf, kernel-team
Drivers are supposed to advertise the XDP features they support. This was
missed while adding XDP support.
Before:
$ ynl --family netdev --dump dev-get
...
{'ifindex': 3,
'xdp-features': set(),
'xdp-rx-metadata-features': set(),
'xsk-features': set()},
...
After:
$ ynl --family netdev --dump dev-get
...
{'ifindex': 3,
'xdp-features': {'basic', 'rx-sg'},
'xdp-rx-metadata-features': set(),
'xsk-features': set()},
...
Fixes: 168deb7b31b2 ("eth: fbnic: Add support for XDP_TX action")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
---
drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
index e3ca5fcfabef..b4b396ca9bce 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
@@ -805,6 +805,8 @@ struct net_device *fbnic_netdev_alloc(struct fbnic_dev *fbd)
netdev->hw_enc_features |= netdev->features;
netdev->features |= NETIF_F_NTUPLE;
+ netdev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_RX_SG;
+
netdev->min_mtu = IPV6_MIN_MTU;
netdev->max_mtu = FBNIC_MAX_JUMBO_FRAME_SIZE - ETH_HLEN;
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] eth: fbnic: Advertise supported XDP features.
2026-02-18 3:06 [PATCH net] eth: fbnic: Advertise supported XDP features Dimitri Daskalakis
@ 2026-02-18 10:05 ` Simon Horman
2026-02-19 17:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-02-18 10:05 UTC (permalink / raw)
To: Dimitri Daskalakis
Cc: David S. Miller, Alexander Duyck, Jakub Kicinski, Eric Dumazet,
Paolo Abeni, Andrew Lunn, Alexei Starovoitov, Daniel Borkmann,
Jesper Dangaard Brouer, John Fastabend, Stanislav Fomichev,
Mohsin Bashir, netdev, bpf, kernel-team
On Tue, Feb 17, 2026 at 07:06:20PM -0800, Dimitri Daskalakis wrote:
> Drivers are supposed to advertise the XDP features they support. This was
> missed while adding XDP support.
>
> Before:
> $ ynl --family netdev --dump dev-get
> ...
> {'ifindex': 3,
> 'xdp-features': set(),
> 'xdp-rx-metadata-features': set(),
> 'xsk-features': set()},
> ...
>
> After:
> $ ynl --family netdev --dump dev-get
> ...
> {'ifindex': 3,
> 'xdp-features': {'basic', 'rx-sg'},
> 'xdp-rx-metadata-features': set(),
> 'xsk-features': set()},
> ...
>
> Fixes: 168deb7b31b2 ("eth: fbnic: Add support for XDP_TX action")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] eth: fbnic: Advertise supported XDP features.
2026-02-18 3:06 [PATCH net] eth: fbnic: Advertise supported XDP features Dimitri Daskalakis
2026-02-18 10:05 ` Simon Horman
@ 2026-02-19 17:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-19 17:10 UTC (permalink / raw)
To: Dimitri Daskalakis
Cc: davem, alexanderduyck, kuba, edumazet, pabeni, andrew+netdev,
horms, ast, daniel, hawk, john.fastabend, sdf, mohsin.bashr,
netdev, bpf, kernel-team
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 17 Feb 2026 19:06:20 -0800 you wrote:
> Drivers are supposed to advertise the XDP features they support. This was
> missed while adding XDP support.
>
> Before:
> $ ynl --family netdev --dump dev-get
> ...
> {'ifindex': 3,
> 'xdp-features': set(),
> 'xdp-rx-metadata-features': set(),
> 'xsk-features': set()},
> ...
>
> [...]
Here is the summary with links:
- [net] eth: fbnic: Advertise supported XDP features.
https://git.kernel.org/netdev/net/c/e977fcb3a318
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-19 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 3:06 [PATCH net] eth: fbnic: Advertise supported XDP features Dimitri Daskalakis
2026-02-18 10:05 ` Simon Horman
2026-02-19 17:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox