public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	kurt@linutronix.de, pabeni@redhat.com, horms@kernel.org,
	willemb@google.com
Subject: Re: [PATCH net v2] net: Drop the lock in skb_may_tx_timestamp()
Date: Tue, 24 Feb 2026 10:50:06 +0000	[thread overview]
Message-ID: <177193020629.3444651.13248671448207071630.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260220183858.N4ERjFW6@linutronix.de>

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 20 Feb 2026 19:38:58 +0100 you wrote:
> skb_may_tx_timestamp() may acquire sock::sk_callback_lock. The lock must
> not be taken in IRQ context, only softirq is okay. A few drivers receive
> the timestamp via a dedicated interrupt and complete the TX timestamp
> from that handler. This will lead to a deadlock if the lock is already
> write-locked on the same CPU.
> 
> Taking the lock can be avoided. The socket (pointed by the skb) will
> remain valid until the skb is released. The ->sk_socket and ->file
> member will be set to NULL once the user closes the socket which may
> happen before the timestamp arrives.
> If we happen to observe the pointer while the socket is closing but
> before the pointer is set to NULL then we may use it because both
> pointer (and the file's cred member) are RCU freed.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: Drop the lock in skb_may_tx_timestamp()
    https://git.kernel.org/netdev/net/c/983512f3a87f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



  parent reply	other threads:[~2026-02-24 10:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 18:38 [PATCH net v2] net: Drop the lock in skb_may_tx_timestamp() Sebastian Andrzej Siewior
2026-02-20 21:20 ` Willem de Bruijn
2026-02-20 21:29 ` Jakub Kicinski
2026-02-20 21:49   ` Willem de Bruijn
2026-02-20 22:02     ` Jakub Kicinski
2026-02-23 17:07       ` Sebastian Andrzej Siewior
2026-02-23 23:27         ` Jakub Kicinski
2026-02-24  9:02           ` Eric Dumazet
2026-02-24 10:26             ` Paolo Abeni
2026-02-21  0:45 ` Jason Xing
2026-02-23  8:42 ` Eric Dumazet
2026-02-24 10:50 ` patchwork-bot+netdevbpf [this message]
2026-02-26  8:11   ` Kurt Kanzenbach
2026-02-26  8:50     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177193020629.3444651.13248671448207071630.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox