* [PATCH net-next] net: freescale: ucc_geth: call of_node_put once
@ 2026-02-24 1:41 Rosen Penev
2026-02-24 17:13 ` Simon Horman
2026-02-25 4:09 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2026-02-24 1:41 UTC (permalink / raw)
To: netdev
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, open list:FREESCALE QUICC ENGINE UCC ETHERNET DRIVER,
open list
Move it up to avoid placing it in both the error and success paths.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 78d72409b6e0..4d598693d7a6 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3470,14 +3470,13 @@ static int ucc_geth_probe(struct platform_device* ofdev)
phy_node = of_parse_phandle(np, "phy-handle", 0);
if (phy_node) {
prop = of_get_property(phy_node, "interface", NULL);
+ of_node_put(phy_node);
if (prop) {
dev_err(&ofdev->dev,
"Device-tree property 'interface' is no longer supported. Please use 'phy-connection-type' instead.");
- of_node_put(phy_node);
err = -EINVAL;
goto err_put_tbi;
}
- of_node_put(phy_node);
}
err = of_get_phy_mode(np, &phy_interface);
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: freescale: ucc_geth: call of_node_put once
2026-02-24 1:41 [PATCH net-next] net: freescale: ucc_geth: call of_node_put once Rosen Penev
@ 2026-02-24 17:13 ` Simon Horman
2026-02-25 4:09 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-02-24 17:13 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni,
open list:FREESCALE QUICC ENGINE UCC ETHERNET DRIVER, open list,
Maxime Chevallier
+ Maxime
On Mon, Feb 23, 2026 at 05:41:41PM -0800, Rosen Penev wrote:
> Move it up to avoid placing it in both the error and success paths.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
> index 78d72409b6e0..4d598693d7a6 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3470,14 +3470,13 @@ static int ucc_geth_probe(struct platform_device* ofdev)
> phy_node = of_parse_phandle(np, "phy-handle", 0);
> if (phy_node) {
> prop = of_get_property(phy_node, "interface", NULL);
> + of_node_put(phy_node);
> if (prop) {
> dev_err(&ofdev->dev,
> "Device-tree property 'interface' is no longer supported. Please use 'phy-connection-type' instead.");
> - of_node_put(phy_node);
> err = -EINVAL;
> goto err_put_tbi;
> }
> - of_node_put(phy_node);
> }
>
> err = of_get_phy_mode(np, &phy_interface);
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: freescale: ucc_geth: call of_node_put once
2026-02-24 1:41 [PATCH net-next] net: freescale: ucc_geth: call of_node_put once Rosen Penev
2026-02-24 17:13 ` Simon Horman
@ 2026-02-25 4:09 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-25 4:09 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew+netdev, davem, edumazet, kuba, pabeni,
linuxppc-dev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 23 Feb 2026 17:41:41 -0800 you wrote:
> Move it up to avoid placing it in both the error and success paths.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> [...]
Here is the summary with links:
- [net-next] net: freescale: ucc_geth: call of_node_put once
https://git.kernel.org/netdev/net-next/c/d2adf01780b8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-25 4:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24 1:41 [PATCH net-next] net: freescale: ucc_geth: call of_node_put once Rosen Penev
2026-02-24 17:13 ` Simon Horman
2026-02-25 4:09 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox