* [PATCH] NFC: fix header file kernel-doc warnings
@ 2026-02-26 22:10 Randy Dunlap
2026-02-28 3:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2026-02-26 22:10 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, Krzysztof Kozlowski, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman
Repair some of the comments:
- use the correct enum names
- don't use "/**" for a non-kernel-doc comment
to fix these warnings:
Warning: include/uapi/linux/nfc.h:127 Excess enum value
'@NFC_EVENT_DEVICE_DEACTIVATED' description in 'nfc_commands'
Warning: include/uapi/linux/nfc.h:204 Excess enum value
'@NFC_ATTR_APDU' description in 'nfc_attrs'
Warning: include/uapi/linux/nfc.h:302 expecting prototype for Pseudo().
Prototype was for NFC_RAW_HEADER_SIZE() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>
include/uapi/linux/nfc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20260226.orig/include/uapi/linux/nfc.h
+++ linux-next-20260226/include/uapi/linux/nfc.h
@@ -55,7 +55,7 @@
* (it sends %NFC_ATTR_DEVICE_INDEX)
* @NFC_EVENT_TM_ACTIVATED: event emitted when the adapter is activated in
* target mode.
- * @NFC_EVENT_DEVICE_DEACTIVATED: event emitted when the adapter is deactivated
+ * @NFC_EVENT_TM_DEACTIVATED: event emitted when the adapter is deactivated
* from target mode.
* @NFC_CMD_LLC_GET_PARAMS: request LTO, RW, and MIUX parameters for a device
* @NFC_CMD_LLC_SET_PARAMS: set one or more of LTO, RW, and MIUX parameters for
@@ -156,7 +156,7 @@ enum nfc_commands {
* @NFC_ATTR_SE_INDEX: Secure element index
* @NFC_ATTR_SE_TYPE: Secure element type (UICC or EMBEDDED)
* @NFC_ATTR_FIRMWARE_DOWNLOAD_STATUS: Firmware download operation status
- * @NFC_ATTR_APDU: Secure element APDU
+ * @NFC_ATTR_SE_APDU: Secure element APDU
* @NFC_ATTR_TARGET_ISO15693_DSFID: ISO 15693 Data Storage Format Identifier
* @NFC_ATTR_TARGET_ISO15693_UID: ISO 15693 Unique Identifier
* @NFC_ATTR_SE_PARAMS: Parameters data from an evt_transaction
@@ -291,7 +291,7 @@ struct sockaddr_nfc_llcp {
#define NFC_HEADER_SIZE 1
-/**
+/*
* Pseudo-header info for raw socket packets
* First byte is the adapter index
* Second byte contains flags
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] NFC: fix header file kernel-doc warnings
2026-02-26 22:10 [PATCH] NFC: fix header file kernel-doc warnings Randy Dunlap
@ 2026-02-28 3:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-02-28 3:40 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, krzk, davem, edumazet, kuba, pabeni, horms
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 26 Feb 2026 14:10:04 -0800 you wrote:
> Repair some of the comments:
> - use the correct enum names
> - don't use "/**" for a non-kernel-doc comment
>
> to fix these warnings:
>
> Warning: include/uapi/linux/nfc.h:127 Excess enum value
> '@NFC_EVENT_DEVICE_DEACTIVATED' description in 'nfc_commands'
> Warning: include/uapi/linux/nfc.h:204 Excess enum value
> '@NFC_ATTR_APDU' description in 'nfc_attrs'
> Warning: include/uapi/linux/nfc.h:302 expecting prototype for Pseudo().
> Prototype was for NFC_RAW_HEADER_SIZE() instead
>
> [...]
Here is the summary with links:
- NFC: fix header file kernel-doc warnings
https://git.kernel.org/netdev/net-next/c/2164242c5008
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-28 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 22:10 [PATCH] NFC: fix header file kernel-doc warnings Randy Dunlap
2026-02-28 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox