From: patchwork-bot+netdevbpf@kernel.org
To: MD Danish Anwar <danishanwar@ti.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, m-malladi@ti.com,
jacob.e.keller@intel.com, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org, srk@ti.com,
vigneshr@ti.com, rogerq@kernel.org
Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix ping failure after offload mode setup when link speed is not 1G
Date: Sat, 28 Feb 2026 22:24:36 +0000 [thread overview]
Message-ID: <177231747630.3111473.16483515662325090090.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260226102356.2141871-1-danishanwar@ti.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 26 Feb 2026 15:53:56 +0530 you wrote:
> When both eth interfaces with links up are added to a bridge or hsr
> interface, ping fails if the link speed is not 1Gbps (e.g., 100Mbps).
>
> The issue is seen because when switching to offload (bridge/hsr) mode,
> prueth_emac_restart() restarts the firmware and clears DRAM with
> memset_io(), setting all memory to 0. This includes PORT_LINK_SPEED_OFFSET
> which firmware reads for link speed. The value 0 corresponds to
> FW_LINK_SPEED_1G (0x00), so for 1Gbps links the default value is correct
> and ping works. For 100Mbps links, the firmware needs FW_LINK_SPEED_100M
> (0x01) but gets 0 instead, causing ping to fail. The function
> emac_adjust_link() is called to reconfigure, but it detects no state change
> (emac->link is still 1, speed/duplex match PHY) so new_state remains false
> and icssg_config_set_speed() is never called to correct the firmware speed
> value.
>
> [...]
Here is the summary with links:
- [net] net: ti: icssg-prueth: Fix ping failure after offload mode setup when link speed is not 1G
https://git.kernel.org/netdev/net/c/147792c395db
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-02-28 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 10:23 [PATCH net] net: ti: icssg-prueth: Fix ping failure after offload mode setup when link speed is not 1G MD Danish Anwar
2026-02-28 22:24 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177231747630.3111473.16483515662325090090.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox