[PATCH net] netconsole: fix sysdata_release_enabled_show checking wrong flag

[PATCH net] netconsole: fix sysdata_release_enabled_show checking wrong flag

[Breno Leitao]

sysdata_release_enabled_show() checks SYSDATA_TASKNAME instead of
SYSDATA_RELEASE, causing the configfs release_enabled attribute to
reflect the taskname feature state rather than the release feature
state. This is a copy-paste error from the adjacent
sysdata_taskname_enabled_show() function.

The corresponding _store function already uses the correct
SYSDATA_RELEASE flag.

Fixes: 343f90227070 ("netconsole: implement configfs for release_enabled")
Signed-off-by: Breno Leitao <leitao@debian.org>
Cc: stable@vger.kernel.org
---
 drivers/net/netconsole.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 2db116fb1a7cd..3c9acd6e49e86 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -617,7 +617,7 @@ static ssize_t sysdata_release_enabled_show(struct config_item *item,
 	bool release_enabled;
 
 	dynamic_netconsole_mutex_lock();
-	release_enabled = !!(nt->sysdata_fields & SYSDATA_TASKNAME);
+	release_enabled = !!(nt->sysdata_fields & SYSDATA_RELEASE);
 	dynamic_netconsole_mutex_unlock();
 
 	return sysfs_emit(buf, "%d\n", release_enabled);

---
base-commit: 11439c4635edd669ae435eec308f4ab8a0804808
change-id: 20260302-sysdata_release_fix-c3d3a1606bc5

Best regards,
--  
Breno Leitao <leitao@debian.org>

Re: [PATCH net] netconsole: fix sysdata_release_enabled_show checking wrong flag

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 02 Mar 2026 03:40:46 -0800 you wrote:
> sysdata_release_enabled_show() checks SYSDATA_TASKNAME instead of
> SYSDATA_RELEASE, causing the configfs release_enabled attribute to
> reflect the taskname feature state rather than the release feature
> state. This is a copy-paste error from the adjacent
> sysdata_taskname_enabled_show() function.
> 
> The corresponding _store function already uses the correct
> SYSDATA_RELEASE flag.
> 
> [...]

Here is the summary with links:
  - [net] netconsole: fix sysdata_release_enabled_show checking wrong flag
    https://git.kernel.org/netdev/net/c/5af6e8b54927

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html