From: patchwork-bot+netdevbpf@kernel.org
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org,
claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
wei.fang@nxp.com, xiaoning.wang@nxp.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, sdf@fomichev.me, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, kpsingh@kernel.org, haoluo@google.com,
jolsa@kernel.org, horms@kernel.org, shuah@kernel.org,
aleksander.lobakin@intel.com, maciej.fijalkowski@intel.com,
bastien.curutchet@bootlin.com, tushar.vyavahare@intel.com,
kernelxing@tencent.com, rbm@suse.com, echaudro@redhat.com,
lorenzo@kernel.org, toke@redhat.com, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-kselftest@vger.kernel.org, aleksandr.loktionov@intel.com,
dtatulea@nvidia.com, magnus.karlsson@intel.com
Subject: Re: [PATCH net v5 1/9] xdp: use modulo operation to calculate XDP frag tailroom
Date: Thu, 05 Mar 2026 16:10:28 +0000 [thread overview]
Message-ID: <177272702805.3188128.16309701518912320444.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260305111253.2317394-2-larysa.zaremba@intel.com>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 5 Mar 2026 12:12:42 +0100 you wrote:
> The current formula for calculating XDP tailroom in mbuf packets works only
> if each frag has its own page (if rxq->frag_size is PAGE_SIZE), this
> defeats the purpose of the parameter overall and without any indication
> leads to negative calculated tailroom on at least half of frags, if shared
> pages are used.
>
> There are not many drivers that set rxq->frag_size. Among them:
> * i40e and enetc always split page uniformly between frags, use shared
> pages
> * ice uses page_pool frags via libeth, those are power-of-2 and uniformly
> distributed across page
> * idpf has variable frag_size with XDP on, so current API is not applicable
> * mlx5, mtk and mvneta use PAGE_SIZE or 0 as frag_size for page_pool
>
> [...]
Here is the summary with links:
- [net,v5,1/9] xdp: use modulo operation to calculate XDP frag tailroom
https://git.kernel.org/netdev/net/c/88b6b7f7b216
- [net,v5,2/9] xsk: introduce helper to determine rxq->frag_size
https://git.kernel.org/netdev/net/c/16394d805399
- [net,v5,3/9] ice: fix rxq info registering in mbuf packets
https://git.kernel.org/netdev/net/c/02852b47c706
- [net,v5,4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz
https://git.kernel.org/netdev/net/c/e142dc4ef0f4
- [net,v5,5/9] i40e: fix registering XDP RxQ info
https://git.kernel.org/netdev/net/c/8f497dc8a614
- [net,v5,6/9] i40e: use xdp.frame_sz as XDP RxQ info frag_size
https://git.kernel.org/netdev/net/c/c69d22c6c46a
- [net,v5,7/9] libeth, idpf: use truesize as XDP RxQ info frag_size
https://git.kernel.org/netdev/net/c/75d9228982f2
- [net,v5,8/9] net: enetc: use truesize as XDP RxQ info frag_size
https://git.kernel.org/netdev/net/c/f8e18abf183d
- [net,v5,9/9] xdp: produce a warning when calculated tailroom is negative
https://git.kernel.org/netdev/net/c/8821e857759b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2026-03-05 16:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 11:12 [PATCH net v5 0/9] Address XDP frags having negative tailroom Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 1/9] xdp: use modulo operation to calculate XDP frag tailroom Larysa Zaremba
2026-03-05 16:10 ` patchwork-bot+netdevbpf [this message]
2026-03-05 11:12 ` [PATCH net v5 2/9] xsk: introduce helper to determine rxq->frag_size Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 3/9] ice: fix rxq info registering in mbuf packets Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 4/9] ice: change XDP RxQ frag_size from DMA write length to xdp.frame_sz Larysa Zaremba
2026-03-05 15:08 ` Frank Li
2026-03-05 15:18 ` Vladimir Oltean
2026-03-05 15:25 ` Frank Li
2026-03-05 11:12 ` [PATCH net v5 5/9] i40e: fix registering XDP RxQ info Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 6/9] i40e: use xdp.frame_sz as XDP RxQ info frag_size Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 7/9] libeth, idpf: use truesize " Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 8/9] net: enetc: " Larysa Zaremba
2026-03-05 11:12 ` [PATCH net v5 9/9] xdp: produce a warning when calculated tailroom is negative Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177272702805.3188128.16309701518912320444.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=bpf@vger.kernel.org \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=echaudro@redhat.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernelxing@tencent.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rbm@suse.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=toke@redhat.com \
--cc=tushar.vyavahare@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox