From: patchwork-bot+netdevbpf@kernel.org
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: netdev@vger.kernel.org, nicolas.ferre@microchip.com,
claudiu.beznea@tuxon.dev, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, theo.lebrun@bootlin.com, phil@raspberrypi.com
Subject: Re: [PATCH net-next v6 0/5] net: cadence: macb: add IEEE 802.3az EEE support
Date: Fri, 06 Mar 2026 03:33:00 +0000 [thread overview]
Message-ID: <177276798054.3348267.8349678180512158704.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260304105432.631186-1-nb@tipi-net.de>
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 4 Mar 2026 11:54:27 +0100 you wrote:
> Add Energy Efficient Ethernet (IEEE 802.3az) support to the Cadence GEM
> (macb) driver using phylink's managed EEE framework. The GEM MAC has
> hardware LPI registers but no built-in idle timer, so the driver
> implements software-managed TX LPI using a delayed_work timer while
> delegating EEE negotiation and ethtool state to phylink.
>
> Changes from v5:
> - macb_tx_lpi_set() no longer manages its own spinlock; it now
> requires bp->lock to be held by the caller and asserts this with
> lockdep_assert_held(). All callers (macb_tx_lpi_work_fn,
> macb_mac_enable_tx_lpi, macb_mac_disable_tx_lpi) take bp->lock
> explicitly. Based on feedback from Jakub Kicinski.
> - macb_tx_lpi_wake() is now called under the existing bp->lock in
> macb_start_xmit(), eliminating the redundant lock acquire/release.
> An eee_active check at the top of macb_tx_lpi_wake() short-circuits
> the register read on the common (EEE-disabled) path. Based on
> feedback from Jakub Kicinski.
> - macb_tx_all_queues_idle() uses READ_ONCE for tx_head/tx_tail
> (called under bp->lock; taking tx_ptr_lock here would invert the
> established lock order). Loop rewritten to match the driver
> convention: for (q = 0, queue = bp->queues; ...; ++q, ++queue).
> Based on feedback from Jakub Kicinski and Claudiu Beznea.
> - Added Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev> to
> patches 1-4.
>
> [...]
Here is the summary with links:
- [net-next,v6,1/5] net: cadence: macb: add EEE LPI statistics counters
https://git.kernel.org/netdev/net-next/c/237577e603ce
- [net-next,v6,2/5] net: cadence: macb: implement EEE TX LPI support
https://git.kernel.org/netdev/net-next/c/0cc425f18f59
- [net-next,v6,3/5] net: cadence: macb: add ethtool EEE support
https://git.kernel.org/netdev/net-next/c/61332b78761c
- [net-next,v6,4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1
https://git.kernel.org/netdev/net-next/c/92ba3307431a
- [net-next,v6,5/5] net: cadence: macb: enable EEE for Mobileye EyeQ5
https://git.kernel.org/netdev/net-next/c/48575b6e16d1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-03-06 3:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 10:54 [PATCH net-next v6 0/5] net: cadence: macb: add IEEE 802.3az EEE support Nicolai Buchwitz
2026-03-04 10:54 ` [PATCH net-next v6 1/5] net: cadence: macb: add EEE LPI statistics counters Nicolai Buchwitz
2026-03-04 10:54 ` [PATCH net-next v6 2/5] net: cadence: macb: implement EEE TX LPI support Nicolai Buchwitz
2026-03-04 10:54 ` [PATCH net-next v6 3/5] net: cadence: macb: add ethtool EEE support Nicolai Buchwitz
2026-03-04 10:54 ` [PATCH net-next v6 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1 Nicolai Buchwitz
2026-03-04 10:54 ` [PATCH net-next v6 5/5] net: cadence: macb: enable EEE for Mobileye EyeQ5 Nicolai Buchwitz
2026-03-06 3:33 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177276798054.3348267.8349678180512158704.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.com \
--cc=theo.lebrun@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox