[PATCH v2 net-next] Revert "net: phy: improve mdiobus_stats_acct"

[PATCH v2 net-next] Revert "net: phy: improve mdiobus_stats_acct"

[Heiner Kallweit]

This reverts commit 1afccc5a201ec7c9023370958bae1312369b64da.

As reported by Marek the change causes a warning on non-PREEMPT_RT
32 bit systems.

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- add missing SoB
---
 drivers/net/phy/mdio_bus.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index cf5ce1ed48c..00d0e4159e9 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -60,17 +60,22 @@ EXPORT_SYMBOL(mdiobus_is_registered_device);
 
 static void mdiobus_stats_acct(struct mdio_bus_stats *stats, bool op, int ret)
 {
+	preempt_disable();
 	u64_stats_update_begin(&stats->syncp);
 
 	u64_stats_inc(&stats->transfers);
-	if (ret < 0)
+	if (ret < 0) {
 		u64_stats_inc(&stats->errors);
-	else if (op)
+		goto out;
+	}
+
+	if (op)
 		u64_stats_inc(&stats->reads);
 	else
 		u64_stats_inc(&stats->writes);
-
+out:
 	u64_stats_update_end(&stats->syncp);
+	preempt_enable();
 }
 
 /**
-- 
2.53.0

Re: [PATCH v2 net-next] Revert "net: phy: improve mdiobus_stats_acct"

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 5 Mar 2026 18:42:04 +0100 you wrote:
> This reverts commit 1afccc5a201ec7c9023370958bae1312369b64da.
> 
> As reported by Marek the change causes a warning on non-PREEMPT_RT
> 32 bit systems.
> 
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> [...]

Here is the summary with links:
  - [v2,net-next] Revert "net: phy: improve mdiobus_stats_acct"
    https://git.kernel.org/netdev/net-next/c/1a9940317c1b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html