* [PATCH net-next] tools: ynl: cli: order set->list conversion in JSON output
@ 2026-03-07 17:59 Jakub Kicinski
2026-03-11 1:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2026-03-07 17:59 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski,
donald.hunter, sdf, gal
NIPA tries to make sure that HW tests don't modify system state.
It dumps some well known configs before and after the test and
compares the outputs.
Make sure that YNL json output is stable. Converting sets to lists
with a naive list(o) results in a random order.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: donald.hunter@gmail.com
CC: sdf@fomichev.me
CC: gal@nvidia.com
---
tools/net/ynl/pyynl/cli.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/ynl/pyynl/cli.py b/tools/net/ynl/pyynl/cli.py
index 94a5ba348b69..b452d4fb9434 100755
--- a/tools/net/ynl/pyynl/cli.py
+++ b/tools/net/ynl/pyynl/cli.py
@@ -78,7 +78,7 @@ RELATIVE_SCHEMA_DIR='../../../../Documentation/netlink'
if isinstance(o, bytes):
return bytes.hex(o)
if isinstance(o, set):
- return list(o)
+ return sorted(o)
return json.JSONEncoder.default(self, o)
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] tools: ynl: cli: order set->list conversion in JSON output
2026-03-07 17:59 [PATCH net-next] tools: ynl: cli: order set->list conversion in JSON output Jakub Kicinski
@ 2026-03-11 1:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-11 1:00 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms,
donald.hunter, sdf, gal
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 7 Mar 2026 09:59:16 -0800 you wrote:
> NIPA tries to make sure that HW tests don't modify system state.
> It dumps some well known configs before and after the test and
> compares the outputs.
>
> Make sure that YNL json output is stable. Converting sets to lists
> with a naive list(o) results in a random order.
>
> [...]
Here is the summary with links:
- [net-next] tools: ynl: cli: order set->list conversion in JSON output
https://git.kernel.org/netdev/net-next/c/b8a0e5eb6a12
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-11 1:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-07 17:59 [PATCH net-next] tools: ynl: cli: order set->list conversion in JSON output Jakub Kicinski
2026-03-11 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox