[PATCH net] net: dsa: mxl862xx: don't set user_mii_bus

[PATCH net] net: dsa: mxl862xx: don't set user_mii_bus

[Daniel Golle]

The PHY addresses in the MII bus are not equal to the port addresses,
so the bus cannot be assigned as user_mii_bus. Falling back on the
user_mii_bus in case a PHY isn't declared in device tree will result in
using the wrong (in this case: off-by-+1) PHY.
Remove the wrong assignment.

Fixes: 23794bec1cb60 ("net: dsa: add basic initial driver for MxL862xx switches")
Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
 drivers/net/dsa/mxl862xx/mxl862xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/dsa/mxl862xx/mxl862xx.c b/drivers/net/dsa/mxl862xx/mxl862xx.c
index b1e2094b58165..d7ab04f5afefd 100644
--- a/drivers/net/dsa/mxl862xx/mxl862xx.c
+++ b/drivers/net/dsa/mxl862xx/mxl862xx.c
@@ -149,7 +149,6 @@ static int mxl862xx_setup_mdio(struct dsa_switch *ds)
 		return -ENOMEM;
 
 	bus->priv = priv;
-	ds->user_mii_bus = bus;
 	bus->name = KBUILD_MODNAME "-mii";
 	snprintf(bus->id, MII_BUS_ID_SIZE, "%s-mii", dev_name(dev));
 	bus->read_c45 = mxl862xx_phy_read_c45_mii_bus;
-- 
2.53.0

Re: [PATCH net] net: dsa: mxl862xx: don't set user_mii_bus

[Vladimir Oltean]

On Tue, Mar 10, 2026 at 12:41:56AM +0000, Daniel Golle wrote:
> The PHY addresses in the MII bus are not equal to the port addresses,
> so the bus cannot be assigned as user_mii_bus. Falling back on the
> user_mii_bus in case a PHY isn't declared in device tree will result in
> using the wrong (in this case: off-by-+1) PHY.
> Remove the wrong assignment.
> 
> Fixes: 23794bec1cb60 ("net: dsa: add basic initial driver for MxL862xx switches")
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Re: [PATCH net] net: dsa: mxl862xx: don't set user_mii_bus

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 10 Mar 2026 00:41:56 +0000 you wrote:
> The PHY addresses in the MII bus are not equal to the port addresses,
> so the bus cannot be assigned as user_mii_bus. Falling back on the
> user_mii_bus in case a PHY isn't declared in device tree will result in
> using the wrong (in this case: off-by-+1) PHY.
> Remove the wrong assignment.
> 
> Fixes: 23794bec1cb60 ("net: dsa: add basic initial driver for MxL862xx switches")
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> 
> [...]

Here is the summary with links:
  - [net] net: dsa: mxl862xx: don't set user_mii_bus
    https://git.kernel.org/netdev/net/c/f441b489cc66

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html