* [PATCH] ynl: ethtool: remove duplicated unspec entry
@ 2026-03-11 3:22 Hangbin Liu
2026-03-12 0:25 ` Jakub Kicinski
2026-03-13 1:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Hangbin Liu @ 2026-03-11 3:22 UTC (permalink / raw)
To: Andrew Lunn, Jakub Kicinski, Donald Hunter, David S. Miller,
Eric Dumazet, Paolo Abeni, Simon Horman, Stanislav Fomichev
Cc: netdev, linux-kernel, Hangbin Liu
There is a duplicated unspec entry. Remove it.
Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
Documentation/netlink/specs/ethtool.yaml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 0a2d2343f79a..f47e9e68889a 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -306,10 +306,6 @@ attribute-sets:
name: strings
attr-cnt-name: __ethtool-a-strings-cnt
attributes:
- -
- name: unspec
- type: unused
- value: 0
-
name: unspec
type: unused
---
base-commit: 73aefba4e2eb713cf7bc4ad83cfc9b5d4f966f6d
change-id: 20260311-b4-drop_dup_unspec-2d316fa82d51
Best regards,
--
Hangbin Liu <liuhangbin@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ynl: ethtool: remove duplicated unspec entry
2026-03-11 3:22 [PATCH] ynl: ethtool: remove duplicated unspec entry Hangbin Liu
@ 2026-03-12 0:25 ` Jakub Kicinski
2026-03-12 0:57 ` Hangbin Liu
2026-03-13 1:00 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2026-03-12 0:25 UTC (permalink / raw)
To: Hangbin Liu
Cc: Andrew Lunn, Donald Hunter, David S. Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Stanislav Fomichev, netdev,
linux-kernel
On Wed, 11 Mar 2026 11:22:29 +0800 Hangbin Liu wrote:
> There is a duplicated unspec entry. Remove it.
>
> Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")
Does it break some user space that assumes no duplicates?
Otherwise I think we can merge it via net-next. (no need to repost)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ynl: ethtool: remove duplicated unspec entry
2026-03-12 0:25 ` Jakub Kicinski
@ 2026-03-12 0:57 ` Hangbin Liu
0 siblings, 0 replies; 4+ messages in thread
From: Hangbin Liu @ 2026-03-12 0:57 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Andrew Lunn, Donald Hunter, David S. Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Stanislav Fomichev, netdev,
linux-kernel
On Wed, Mar 11, 2026 at 05:25:59PM -0700, Jakub Kicinski wrote:
> On Wed, 11 Mar 2026 11:22:29 +0800 Hangbin Liu wrote:
> > There is a duplicated unspec entry. Remove it.
> >
> > Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")
>
> Does it break some user space that assumes no duplicates?
No
> Otherwise I think we can merge it via net-next. (no need to repost)
Sure, OK for me.
Thanks
Hangbin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ynl: ethtool: remove duplicated unspec entry
2026-03-11 3:22 [PATCH] ynl: ethtool: remove duplicated unspec entry Hangbin Liu
2026-03-12 0:25 ` Jakub Kicinski
@ 2026-03-13 1:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-13 1:00 UTC (permalink / raw)
To: Hangbin Liu
Cc: andrew, kuba, donald.hunter, davem, edumazet, pabeni, horms, sdf,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 11 Mar 2026 11:22:29 +0800 you wrote:
> There is a duplicated unspec entry. Remove it.
>
> Fixes: 0187e602c03c ("ynl: add missing pieces to ethtool spec to better match uapi header")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> Documentation/netlink/specs/ethtool.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> [...]
Here is the summary with links:
- ynl: ethtool: remove duplicated unspec entry
https://git.kernel.org/netdev/net-next/c/7c52f407f28d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-13 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 3:22 [PATCH] ynl: ethtool: remove duplicated unspec entry Hangbin Liu
2026-03-12 0:25 ` Jakub Kicinski
2026-03-12 0:57 ` Hangbin Liu
2026-03-13 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox