[PATCH net] mpls: add missing unregister_netdevice_notifier to mpls_init

[PATCH net] mpls: add missing unregister_netdevice_notifier to mpls_init

[Sabrina Dubroca]

If mpls_init() fails after registering mpls_dev_notifier, it never
gets removed. Add the missing unregister_netdevice_notifier() call to
the error handling path.

Fixes: 5be2062e3080 ("mpls: Handle error of rtnl_register_module().")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
---
 net/mpls/af_mpls.c | 1 +
 1 file changed, 1 insertion(+)

Sorry, Kuniyuki. It's a bit unfair, but prior to your patch, mpls_init
couldn't fail after register_netdevice_notifier :)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index ef9e749d5e08..d5417688f69e 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -2854,6 +2854,7 @@ static int __init mpls_init(void)
 	rtnl_af_unregister(&mpls_af_ops);
 out_unregister_dev_type:
 	dev_remove_pack(&mpls_packet_type);
+	unregister_netdevice_notifier(&mpls_dev_notifier);
 out_unregister_pernet:
 	unregister_pernet_subsys(&mpls_net_ops);
 	goto out;
-- 
2.51.2

Re: [PATCH net] mpls: add missing unregister_netdevice_notifier to mpls_init

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 11 Mar 2026 23:35:09 +0100 you wrote:
> If mpls_init() fails after registering mpls_dev_notifier, it never
> gets removed. Add the missing unregister_netdevice_notifier() call to
> the error handling path.
> 
> Fixes: 5be2062e3080 ("mpls: Handle error of rtnl_register_module().")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> 
> [...]

Here is the summary with links:
  - [net] mpls: add missing unregister_netdevice_notifier to mpls_init
    https://git.kernel.org/netdev/net/c/99600f79b28c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html