public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] netlink: update outdated comment
@ 2026-03-11 13:35 Kexin Sun
  2026-03-13  2:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Kexin Sun @ 2026-03-11 13:35 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, netdev
  Cc: horms, kuniyu, linux-kernel, julia.lawall, xutong.ma, yunbolyu,
	ratnadiraw, Kexin Sun

The function netlink_clear_multicast_users() was removed as unused
in commit 2173f8d953e7 ("netlink: cleanup tap related functions").
Update the comment in netlink_change_ngroups() to remove the stale
reference, replacing it with a general description of the behavior
while preserving the warning.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 net/netlink/af_netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 4d609d5cf406..018d33af25ad 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2108,8 +2108,8 @@ int __netlink_change_ngroups(struct sock *sk, unsigned int groups)
  * This changes the number of multicast groups that are available
  * on a certain netlink family. Note that it is not possible to
  * change the number of groups to below 32. Also note that it does
- * not implicitly call netlink_clear_multicast_users() when the
- * number of groups is reduced.
+ * not implicitly clear listeners from groups that are removed when
+ * the number of groups is reduced.
  *
  * @sk: The kernel netlink socket, as returned by netlink_kernel_create().
  * @groups: The new number of groups.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] netlink: update outdated comment
  2026-03-11 13:35 [PATCH] netlink: update outdated comment Kexin Sun
@ 2026-03-13  2:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-13  2:50 UTC (permalink / raw)
  To: Kexin Sun
  Cc: davem, edumazet, kuba, pabeni, netdev, horms, kuniyu,
	linux-kernel, julia.lawall, xutong.ma, yunbolyu, ratnadiraw

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 11 Mar 2026 21:35:19 +0800 you wrote:
> The function netlink_clear_multicast_users() was removed as unused
> in commit 2173f8d953e7 ("netlink: cleanup tap related functions").
> Update the comment in netlink_change_ngroups() to remove the stale
> reference, replacing it with a general description of the behavior
> while preserving the warning.
> 
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> 
> [...]

Here is the summary with links:
  - netlink: update outdated comment
    https://git.kernel.org/netdev/net-next/c/8f921f610054

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-13  2:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 13:35 [PATCH] netlink: update outdated comment Kexin Sun
2026-03-13  2:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox