* [PATCH net-next] net: enetc: remove stray semicolon
@ 2026-03-13 11:24 Wei Fang
2026-03-14 0:09 ` Joe Damato
2026-03-14 16:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Wei Fang @ 2026-03-13 11:24 UTC (permalink / raw)
To: claudiu.manoil, vladimir.oltean, xiaoning.wang, andrew+netdev,
davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, imx
Remove stray semicolon from ntmp_table_name().
Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/ntmp.c b/drivers/net/ethernet/freescale/enetc/ntmp.c
index 0c1d343253bf..703752995e93 100644
--- a/drivers/net/ethernet/freescale/enetc/ntmp.c
+++ b/drivers/net/ethernet/freescale/enetc/ntmp.c
@@ -227,7 +227,7 @@ static const char *ntmp_table_name(int tbl_id)
return "RSS Table";
default:
return "Unknown Table";
- };
+ }
}
static int ntmp_delete_entry_by_id(struct ntmp_user *user, int tbl_id,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: enetc: remove stray semicolon
2026-03-13 11:24 [PATCH net-next] net: enetc: remove stray semicolon Wei Fang
@ 2026-03-14 0:09 ` Joe Damato
2026-03-14 0:24 ` Vladimir Oltean
2026-03-14 16:20 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 5+ messages in thread
From: Joe Damato @ 2026-03-14 0:09 UTC (permalink / raw)
To: Wei Fang
Cc: claudiu.manoil, vladimir.oltean, xiaoning.wang, andrew+netdev,
davem, edumazet, kuba, pabeni, netdev, linux-kernel, imx
On Fri, Mar 13, 2026 at 07:24:54PM +0800, Wei Fang wrote:
> Remove stray semicolon from ntmp_table_name().
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Hm, I'm not sure, but I suspect this might be rejected due to the note about
cleanup in the docs, which generally seems to discourage this sort of thing:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: enetc: remove stray semicolon
2026-03-14 0:09 ` Joe Damato
@ 2026-03-14 0:24 ` Vladimir Oltean
2026-03-14 1:28 ` Wei Fang
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Oltean @ 2026-03-14 0:24 UTC (permalink / raw)
To: Joe Damato, Wei Fang, claudiu.manoil, xiaoning.wang,
andrew+netdev, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, imx
On Fri, Mar 13, 2026 at 05:09:46PM -0700, Joe Damato wrote:
> On Fri, Mar 13, 2026 at 07:24:54PM +0800, Wei Fang wrote:
> > Remove stray semicolon from ntmp_table_name().
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> > drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Hm, I'm not sure, but I suspect this might be rejected due to the note about
> cleanup in the docs, which generally seems to discourage this sort of thing:
>
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
"simple clean-ups, which are not in the context of other work"
The ENETC NTMP code is under active development, and Wei is developing it.
The semicolon was added in May last year and was found as part of other
review touching that area.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net-next] net: enetc: remove stray semicolon
2026-03-14 0:24 ` Vladimir Oltean
@ 2026-03-14 1:28 ` Wei Fang
0 siblings, 0 replies; 5+ messages in thread
From: Wei Fang @ 2026-03-14 1:28 UTC (permalink / raw)
To: Vladimir Oltean, Joe Damato
Cc: Claudiu Manoil, Clark Wang, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
> > Hm, I'm not sure, but I suspect this might be rejected due to the note about
> > cleanup in the docs, which generally seems to discourage this sort of thing:
> >
> >
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean
> -up-patches
>
> "simple clean-ups, which are not in the context of other work"
>
> The ENETC NTMP code is under active development, and Wei is developing it.
> The semicolon was added in May last year and was found as part of other
> review touching that area.
Yes, this cleanup is for the upcoming NETC switch patches, which has some
changes to ntmp_table_name().
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] net: enetc: remove stray semicolon
2026-03-13 11:24 [PATCH net-next] net: enetc: remove stray semicolon Wei Fang
2026-03-14 0:09 ` Joe Damato
@ 2026-03-14 16:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-14 16:20 UTC (permalink / raw)
To: Wei Fang
Cc: claudiu.manoil, vladimir.oltean, xiaoning.wang, andrew+netdev,
davem, edumazet, kuba, pabeni, netdev, linux-kernel, imx
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 13 Mar 2026 19:24:54 +0800 you wrote:
> Remove stray semicolon from ntmp_table_name().
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] net: enetc: remove stray semicolon
https://git.kernel.org/netdev/net-next/c/f4ce4922df8d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-14 16:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 11:24 [PATCH net-next] net: enetc: remove stray semicolon Wei Fang
2026-03-14 0:09 ` Joe Damato
2026-03-14 0:24 ` Vladimir Oltean
2026-03-14 1:28 ` Wei Fang
2026-03-14 16:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox