From: patchwork-bot+netdevbpf@kernel.org
To: Qingfang Deng <dqfext@gmail.com>
Cc: linux-ppp@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH net-next] ppp: require callers of ppp_dev_name() to hold RCU
Date: Tue, 17 Mar 2026 23:30:05 +0000 [thread overview]
Message-ID: <177379020554.55920.7311741308449112878.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260316092824.479149-1-dqfext@gmail.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 16 Mar 2026 17:28:23 +0800 you wrote:
> ppp_dev_name() holds the RCU read lock internally to protect pch->ppp.
> However, as it returns netdev->name to the caller, the caller should
> also hold either RCU or RTNL lock to prevent the netdev from being
> freed.
>
> The only two references of the function is in the L2TP driver, both of
> which already hold RCU. So remove the internal RCU lock and document
> that callers must hold RCU.
>
> [...]
Here is the summary with links:
- [net-next] ppp: require callers of ppp_dev_name() to hold RCU
https://git.kernel.org/netdev/net-next/c/bb8539e0e609
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-03-17 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 9:28 [PATCH net-next] ppp: require callers of ppp_dev_name() to hold RCU Qingfang Deng
2026-03-17 20:05 ` Breno Leitao
2026-03-17 23:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177379020554.55920.7311741308449112878.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox