From: patchwork-bot+netdevbpf@kernel.org
To: Muhammad Hammad Ijaz <mhijaz@amazon.com>
Cc: marcin.s.wojtas@gmail.com, linux@armlinux.org.uk,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stefanc@marvell.com,
gunnarku@amazon.com
Subject: Re: [PATCH] net: mvpp2: guard flow control update with global_tx_fc in buffer switching
Date: Thu, 19 Mar 2026 09:50:05 +0000 [thread overview]
Message-ID: <177391380529.1122278.3799765225588594880.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260316193157.65748-1-mhijaz@amazon.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 16 Mar 2026 12:31:01 -0700 you wrote:
> mvpp2_bm_switch_buffers() unconditionally calls
> mvpp2_bm_pool_update_priv_fc() when switching between per-cpu and
> shared buffer pool modes. This function programs CM3 flow control
> registers via mvpp2_cm3_read()/mvpp2_cm3_write(), which dereference
> priv->cm3_base without any NULL check.
>
> When the CM3 SRAM resource is not present in the device tree (the
> third reg entry added by commit 60523583b07c ("dts: marvell: add CM3
> SRAM memory to cp11x ethernet device tree")), priv->cm3_base remains
> NULL and priv->global_tx_fc is false. Any operation that triggers
> mvpp2_bm_switch_buffers(), for example an MTU change that crosses
> the jumbo frame threshold, will crash:
>
> [...]
Here is the summary with links:
- net: mvpp2: guard flow control update with global_tx_fc in buffer switching
https://git.kernel.org/netdev/net/c/8a63baadf084
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-03-19 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 19:31 [PATCH] net: mvpp2: guard flow control update with global_tx_fc in buffer switching Muhammad Hammad Ijaz
2026-03-19 9:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177391380529.1122278.3799765225588594880.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gunnarku@amazon.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marcin.s.wojtas@gmail.com \
--cc=mhijaz@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefanc@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox