From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
donald.hunter@gmail.com, chuck.lever@oracle.com,
matttbe@kernel.org, p@1g4.org, ast@fiberby.net, jiri@resnulli.us
Subject: Re: [PATCH net 1/2] net: shaper: protect late read accesses to the hierarchy
Date: Thu, 19 Mar 2026 13:50:05 +0000 [thread overview]
Message-ID: <177392820563.1208461.13325506803372802389.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260317161014.779569-1-kuba@kernel.org>
Hello:
This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 17 Mar 2026 09:10:13 -0700 you wrote:
> We look up a netdev during prep of Netlink ops (pre- callbacks)
> and take a ref to it. Then later in the body of the callback
> we take its lock or RCU which are the actual protections.
>
> This is not proper, a conversion from a ref to a locked netdev
> must include a liveness check (a check if the netdev hasn't been
> unregistered already). Fix the read cases (those under RCU).
> Writes needs a separate change to protect from creating the
> hierarchy after flush has already run.
>
> [...]
Here is the summary with links:
- [net,1/2] net: shaper: protect late read accesses to the hierarchy
https://git.kernel.org/netdev/net/c/0f9ea7141f36
- [net,2/2] net: shaper: protect from late creation of hierarchy
https://git.kernel.org/netdev/net/c/d75ec7e8ba19
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-03-19 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 16:10 [PATCH net 1/2] net: shaper: protect late read accesses to the hierarchy Jakub Kicinski
2026-03-17 16:10 ` [PATCH net 2/2] net: shaper: protect from late creation of hierarchy Jakub Kicinski
2026-03-17 16:33 ` Paul Moses
2026-03-19 13:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177392820563.1208461.13325506803372802389.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p@1g4.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox