From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: netdev@vger.kernel.org
Cc: linux-sh@vger.kernel.org, horms@verge.net.au
Subject: [PATCH 2/2] sh_eth: propagate platform_get_irq() error upstream
Date: Fri, 28 Aug 2015 16:56:01 +0300 [thread overview]
Message-ID: <1774140.R12mtes975@wasted.cogentembedded.com> (raw)
In-Reply-To: <9944836.IRPmWk4iN8@wasted.cogentembedded.com>
The driver overrides the error returned by platform_get_irq() with -ENODEV
which e.g. precludes the deferred probing from working. Propagate the real
error code to the driver core instead.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -3089,10 +3089,8 @@ static int sh_eth_drv_probe(struct platf
ndev->dma = -1;
ret = platform_get_irq(pdev, 0);
- if (ret < 0) {
- ret = -ENODEV;
+ if (ret < 0)
goto out_release;
- }
ndev->irq = ret;
SET_NETDEV_DEV(ndev, &pdev->dev);
next prev parent reply other threads:[~2015-08-28 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 13:54 [PATCH 0/2] Renesas: propagate platform_get_irq() error upstream Sergei Shtylyov
2015-08-28 13:55 ` [PATCH 1/2] ravb: " Sergei Shtylyov
2015-08-28 15:38 ` Geert Uytterhoeven
2015-08-29 5:26 ` David Miller
2015-08-28 13:56 ` Sergei Shtylyov [this message]
2015-08-28 15:39 ` [PATCH 2/2] sh_eth: " Geert Uytterhoeven
2015-08-29 5:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1774140.R12mtes975@wasted.cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).