Re: [PATCH net-next v35 0/8] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor

[Xuan Zhuo <xuanzhuo@linux.alibaba.com>]

On Thu, 26 Mar 2026 12:26:33 +0100, Paolo Abeni <pabeni@redhat.com> wrote:
> On 3/23/26 8:44 AM, Xuan Zhuo wrote:
> > Add a driver framework for EEA that will be available in the future.
> >
> > This driver is currently quite minimal, implementing only fundamental
> > core functionalities. Key features include: I/O queue management via
> > adminq, basic PCI-layer operations, and essential RX/TX data
> > communication capabilities. It also supports the creation,
> > initialization, and management of network devices (netdev). Furthermore,
> > the ring structures for both I/O queues and adminq have been abstracted
> > into a simple, unified, and reusable library implementation,
> > facilitating future extension and maintenance.
>
> Unfortunately sashiko fund more stuff:
>
> https://sashiko.dev/#/patchset/20260323074441.91691-1-xuanzhuo%40linux.alibaba.com
>
> AFAIK checks vs malicious values from the H/W are not due, but stats
> endianness, 32-bits, truesize related concerns looks real.

I've looked at this, and I think most of it is meaningless. For example, since
we have the following options,

+	depends on 64BIT

there's no need to consider some 32-bit related issues. Many other points are
also unnecessary.

I will go through these comments again. I'll try to fix them.
I might introduce some defensive programming. ^_^ Just to make the
AI happy. However, I can't make all these comments disappear.

Currently, Opus's comments are OK. I think Opus's suggestions are more
meaningful.

Thanks.



>
> As for the acceptance criteria, we should not merge code with known
> issues. A problem with this driver submission is the size and complexity
> which allow LLMs to dig different things at different moments.
>
> /P
>