From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58BE61DE8AF for ; Thu, 26 Mar 2026 12:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.119 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774526460; cv=none; b=Iux8FerC20WNhBoTTgNi3SiNzgRER+zQLtjXVnstnyWd4KTKL0YyqJgbdWdfklUpeVGYM/7TugnOcv0s9f20SHQidUISb1ZQhVz9G+H+MB7BbT7OfWpTi6IXgEPLBHH7H/VZSt+4vF30sroutl+6WwnGGEaAzTK2XePJKjerSH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774526460; c=relaxed/simple; bh=b9w5x4PR4Au3exK1pTgox5ELUIf4oFeVm8VO5zfgNWg=; h=Message-ID:Subject:Date:From:To:Cc:References:In-Reply-To; b=d/+zmc1uI06ViutF9S5yVVmbQeOg6vjfkv+wFFFSOYfTpRw7Cjb4wTXQkR55eIBoqjz4NfiFrx5lvM8wKYWrZt1c9Zti+yDAFe/hotZunk2oe4K8L7ddxk+h3gq2EtP6Z8Y6demT9QxJ1Wr1Pyr4nRXftWhTA4fTl1sRoPlB/GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=rAqps1BT; arc=none smtp.client-ip=115.124.30.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="rAqps1BT" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1774526454; h=Message-ID:Subject:Date:From:To; bh=ETdmqNMFWOWHk8c5RCU0dqa9+iYWJARC9GJuc+8aOJA=; b=rAqps1BT3DLzR2EElxSRQO2heCgmLfk3IdMRnReKGRrqM5ClGeKUrpeDP2IU3HkIiJJAgyqV9a5PhMaQdTrGlyXqKvOkPpttWlGtquutfLUW4jgTn8N6fX29xkbw1BLf9zMR9TG+2tyYmwGJIk1405qEKSeJIY3LtBAAsFGJDk4= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033032089153;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0X.lEwhM_1774526133; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0X.lEwhM_1774526133 cluster:ay36) by smtp.aliyun-inc.com; Thu, 26 Mar 2026 19:55:34 +0800 Message-ID: <1774525085.4029815-1-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH net-next v35 0/8] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Date: Thu, 26 Mar 2026 19:38:05 +0800 From: Xuan Zhuo To: Paolo Abeni Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Wen Gu , Philo Lu , Vadim Fedorenko , Dong Yibo , "Ethan Nelson-Moore" , Heiner Kallweit , Vivian Wang , Dust Li , netdev@vger.kernel.org References: <20260323074441.91691-1-xuanzhuo@linux.alibaba.com> In-Reply-To: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: On Thu, 26 Mar 2026 12:26:33 +0100, Paolo Abeni wrote: > On 3/23/26 8:44 AM, Xuan Zhuo wrote: > > Add a driver framework for EEA that will be available in the future. > > > > This driver is currently quite minimal, implementing only fundamental > > core functionalities. Key features include: I/O queue management via > > adminq, basic PCI-layer operations, and essential RX/TX data > > communication capabilities. It also supports the creation, > > initialization, and management of network devices (netdev). Furthermore, > > the ring structures for both I/O queues and adminq have been abstracted > > into a simple, unified, and reusable library implementation, > > facilitating future extension and maintenance. > > Unfortunately sashiko fund more stuff: > > https://sashiko.dev/#/patchset/20260323074441.91691-1-xuanzhuo%40linux.alibaba.com > > AFAIK checks vs malicious values from the H/W are not due, but stats > endianness, 32-bits, truesize related concerns looks real. I've looked at this, and I think most of it is meaningless. For example, since we have the following options, + depends on 64BIT there's no need to consider some 32-bit related issues. Many other points are also unnecessary. I will go through these comments again. I'll try to fix them. I might introduce some defensive programming. ^_^ Just to make the AI happy. However, I can't make all these comments disappear. Currently, Opus's comments are OK. I think Opus's suggestions are more meaningful. Thanks. > > As for the acceptance criteria, we should not merge code with known > issues. A problem with this driver submission is the size and complexity > which allow LLMs to dig different things at different moments. > > /P >