From: patchwork-bot+netdevbpf@kernel.org
To: David Carlier <devnexen@gmail.com>
Cc: pablo@netfilter.org, fw@strlen.de, phil@nwl.cc,
edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: ctnetlink: use netlink policy range checks
Date: Thu, 26 Mar 2026 15:30:27 +0000 [thread overview]
Message-ID: <177453902728.2636466.202984065147410322.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260324171259.318041-1-devnexen@gmail.com>
Hello:
This patch was applied to netdev/net.git (main)
by Pablo Neira Ayuso <pablo@netfilter.org>:
On Tue, 24 Mar 2026 17:12:59 +0000 you wrote:
> Replace manual range and mask validations with netlink policy
> annotations in ctnetlink code paths, so that the netlink core rejects
> invalid values early and can generate extack errors.
>
> - CTA_PROTOINFO_TCP_STATE: reject values > TCP_CONNTRACK_SYN_SENT2 at
> policy level, removing the manual >= TCP_CONNTRACK_MAX check.
> - CTA_PROTOINFO_TCP_WSCALE_ORIGINAL/REPLY: reject values > TCP_MAX_WSCALE
> (14). The normal TCP option parsing path already clamps to this value,
> but the ctnetlink path accepted 0-255, causing undefined behavior when
> used as a u32 shift count.
> - CTA_FILTER_ORIG_FLAGS/REPLY_FLAGS: use NLA_POLICY_MASK with
> CTA_FILTER_F_ALL, removing the manual mask checks.
> - CTA_EXPECT_FLAGS: use NLA_POLICY_MASK with NF_CT_EXPECT_MASK, adding
> a new mask define grouping all valid expect flags.
>
> [...]
Here is the summary with links:
- netfilter: ctnetlink: use netlink policy range checks
https://git.kernel.org/netdev/net/c/8f15b5071b45
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-03-26 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 16:30 [PATCH] netfilter: conntrack: clamp TCP window scale to TCP_MAX_WSCALE via ctnetlink David Carlier
2026-03-24 16:37 ` Florian Westphal
2026-03-24 16:43 ` David CARLIER
2026-03-24 16:50 ` Florian Westphal
2026-03-24 17:12 ` [PATCH] netfilter: ctnetlink: use netlink policy range checks David Carlier
2026-03-26 15:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177453902728.2636466.202984065147410322.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=devnexen@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox