[PATCH net v3 1/1] net: fec: fix the PTP periodic output sysfs interface

[PATCH net v3 1/1] net: fec: fix the PTP periodic output sysfs interface

[Buday Csaba]

When the PPS channel configuration was implemented, the channel
index for the periodic outputs was configured as the hardware
channel number.

The sysfs interface uses a logical channel index, and rejects numbers
greater than `n_per_out` (see period_store() in ptp_sysfs.c).
That property was left at 1, since the driver implements channel
selection, not simultaneous operation of multiple PTP hardware timer
channels.

A second check in fec_ptp_enable() returns -EOPNOTSUPP when the two
channel numbers disagree, making channels 1..3 unusable from sysfs.

Fix by removing this redundant check in the FEC PTP driver.

Fixes: 566c2d83887f ("net: fec: make PPS channel configurable")
Signed-off-by: Buday Csaba <buday.csaba@prolan.hu>
---
 drivers/net/ethernet/freescale/fec_ptp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 4b7bad9a485d..56801c2009d5 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -545,9 +545,6 @@ static int fec_ptp_enable(struct ptp_clock_info *ptp,
 		if (rq->perout.flags)
 			return -EOPNOTSUPP;
 
-		if (rq->perout.index != fep->pps_channel)
-			return -EOPNOTSUPP;
-
 		period.tv_sec = rq->perout.period.sec;
 		period.tv_nsec = rq->perout.period.nsec;
 		period_ns = timespec64_to_ns(&period);

base-commit: 8a63baadf08453f66eb582fdb6dd234f72024723
-- 
2.39.5

Re: [PATCH net v3 1/1] net: fec: fix the PTP periodic output sysfs interface

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 24 Mar 2026 14:32:30 +0100 you wrote:
> When the PPS channel configuration was implemented, the channel
> index for the periodic outputs was configured as the hardware
> channel number.
> 
> The sysfs interface uses a logical channel index, and rejects numbers
> greater than `n_per_out` (see period_store() in ptp_sysfs.c).
> That property was left at 1, since the driver implements channel
> selection, not simultaneous operation of multiple PTP hardware timer
> channels.
> 
> [...]

Here is the summary with links:
  - [net,v3,1/1] net: fec: fix the PTP periodic output sysfs interface
    https://git.kernel.org/netdev/net/c/e8e44c98f789

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html