public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: microchip: dead code cleanup in kconfig for FDMA
@ 2026-03-29 18:53 Julian Braha
  2026-04-02  3:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2026-03-29 18:53 UTC (permalink / raw)
  To: pabeni, davem, daniel.machon
  Cc: andrew+netdev, edumazet, kuba, linux-kernel, netdev, Julian Braha

The Kconfig in the parent directory already has the first 'if NET_VENDOR_MICROCHIP'
gating the inclusion of this Kconfig, meaning that the second
'if NET_VENDOR_MICROCHIP' condition is effectively dead code.

I propose removing the second 'if NET_VENDOR_MICROCHIP' in
drivers/net/ethernet/microchip/fdma/Kconfig

This dead code was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/net/ethernet/microchip/fdma/Kconfig | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/microchip/fdma/Kconfig b/drivers/net/ethernet/microchip/fdma/Kconfig
index ec228c061351..57a54e7167d3 100644
--- a/drivers/net/ethernet/microchip/fdma/Kconfig
+++ b/drivers/net/ethernet/microchip/fdma/Kconfig
@@ -3,8 +3,6 @@
 # Microchip FDMA API configuration
 #
 
-if NET_VENDOR_MICROCHIP
-
 config FDMA
 	bool "FDMA API" if COMPILE_TEST
 	help
@@ -14,5 +12,3 @@ config FDMA
 	  Say Y here if you want to build the FDMA API that provides a common
 	  set of functions and data structures for interacting with the Frame
 	  DMA engine in multiple microchip switchcores.
-
-endif # NET_VENDOR_MICROCHIP
-- 
2.51.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: microchip: dead code cleanup in kconfig for FDMA
  2026-03-29 18:53 [PATCH] net: microchip: dead code cleanup in kconfig for FDMA Julian Braha
@ 2026-04-02  3:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-02  3:20 UTC (permalink / raw)
  To: Julian Braha
  Cc: pabeni, davem, daniel.machon, andrew+netdev, edumazet, kuba,
	linux-kernel, netdev

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 29 Mar 2026 19:53:48 +0100 you wrote:
> The Kconfig in the parent directory already has the first 'if NET_VENDOR_MICROCHIP'
> gating the inclusion of this Kconfig, meaning that the second
> 'if NET_VENDOR_MICROCHIP' condition is effectively dead code.
> 
> I propose removing the second 'if NET_VENDOR_MICROCHIP' in
> drivers/net/ethernet/microchip/fdma/Kconfig
> 
> [...]

Here is the summary with links:
  - net: microchip: dead code cleanup in kconfig for FDMA
    https://git.kernel.org/netdev/net-next/c/48c6255cda81

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-02  3:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-29 18:53 [PATCH] net: microchip: dead code cleanup in kconfig for FDMA Julian Braha
2026-04-02  3:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox